Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 1 | // Copyright 2015 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
| 5 | // Package dashboard contains shared configuration and logic used by various |
| 6 | // pieces of the Go continuous build system. |
| 7 | package dashboard |
| 8 | |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 9 | import ( |
| 10 | "strconv" |
| 11 | "strings" |
| 12 | ) |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 13 | |
| 14 | // Builders are the different build configurations. |
| 15 | // The keys are like "darwin-amd64" or "linux-386-387". |
| 16 | // This map should not be modified by other packages. |
| 17 | var Builders = map[string]BuildConfig{} |
| 18 | |
David Crawshaw | 66c36dd | 2015-04-23 10:23:22 -0400 | [diff] [blame] | 19 | // A BuildConfig describes how to run a builder. |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 20 | type BuildConfig struct { |
| 21 | // Name is the unique name of the builder, in the form of |
| 22 | // "darwin-386" or "linux-amd64-race". |
| 23 | Name string |
| 24 | |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 25 | Notes string // notes for humans |
| 26 | Owner string // e.g. "bradfitz@golang.org", empty means golang-dev |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 27 | VMImage string // e.g. "openbsd-amd64-56" |
Brad Fitzpatrick | 6925ce8 | 2015-09-08 15:18:47 -0700 | [diff] [blame] | 28 | KubeImage string // e.g. "linux-buildlet-std:latest" (suffix after "gcr.io/<PROJ>/") |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 29 | machineType string // optional GCE instance type |
Brad Fitzpatrick | 20d8483 | 2015-01-21 10:03:07 -0800 | [diff] [blame] | 30 | Go14URL string // URL to built Go 1.4 tar.gz |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 31 | buildletURL string // optional override buildlet URL |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 32 | |
David Crawshaw | 66c36dd | 2015-04-23 10:23:22 -0400 | [diff] [blame] | 33 | IsReverse bool // if true, only use the reverse buildlet pool |
Brad Fitzpatrick | 1c6d916 | 2015-03-20 16:14:52 -0700 | [diff] [blame] | 34 | RegularDisk bool // if true, use spinning disk instead of SSD |
Brad Fitzpatrick | eb52e71 | 2015-05-13 18:38:20 -0700 | [diff] [blame] | 35 | TryOnly bool // only used for trybots, and not regular builds |
Brad Fitzpatrick | 1c6d916 | 2015-03-20 16:14:52 -0700 | [diff] [blame] | 36 | |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 37 | // NumTestHelpers is the number of _additional_ buildlets |
| 38 | // past the first help out with sharded tests. |
| 39 | NumTestHelpers int |
| 40 | |
Brad Fitzpatrick | ac39ba8 | 2015-05-14 13:39:58 -0700 | [diff] [blame] | 41 | // BuildletType optionally specifies the type of buildlet to |
| 42 | // request from the buildlet pool. If empty, it defaults to |
| 43 | // the value of Name. |
| 44 | // |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 45 | // These should be used to minimize builder types, so the buildlet pool |
| 46 | // implementations can reuse buildlets from similar-enough builds. |
| 47 | // (e.g. a shared linux-386 trybot can be reused for some linux-amd64 |
| 48 | // or linux-amd64-race tests, etc) |
| 49 | // |
| 50 | // TODO(bradfitz): break BuildConfig up into BuildConfig and |
| 51 | // BuildletConfig and have a BuildConfig refer to a |
| 52 | // BuildletConfig. There's no much confusion now. |
Brad Fitzpatrick | ac39ba8 | 2015-05-14 13:39:58 -0700 | [diff] [blame] | 53 | BuildletType string |
| 54 | |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 55 | env []string // extra environment ("key=value") pairs |
| 56 | allScriptArgs []string |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 57 | } |
| 58 | |
Andrew Gerrand | cae837b | 2015-08-04 12:19:02 +1000 | [diff] [blame] | 59 | func (c *BuildConfig) Env() []string { |
Andrew Gerrand | 61344ad | 2015-08-04 12:43:08 +1000 | [diff] [blame] | 60 | return append([]string{"GO_BUILDER_NAME=" + c.Name}, c.env...) |
Andrew Gerrand | cae837b | 2015-08-04 12:19:02 +1000 | [diff] [blame] | 61 | } |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 62 | |
Brad Fitzpatrick | f3c0193 | 2015-01-15 16:29:16 -0800 | [diff] [blame] | 63 | func (c *BuildConfig) GOOS() string { return c.Name[:strings.Index(c.Name, "-")] } |
| 64 | |
| 65 | func (c *BuildConfig) GOARCH() string { |
| 66 | arch := c.Name[strings.Index(c.Name, "-")+1:] |
| 67 | i := strings.Index(arch, "-") |
| 68 | if i == -1 { |
| 69 | return arch |
| 70 | } |
| 71 | return arch[:i] |
| 72 | } |
| 73 | |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 74 | // FilePathJoin is mostly like filepath.Join (without the cleaning) except |
| 75 | // it uses the path separator of c.GOOS instead of the host system's. |
| 76 | func (c *BuildConfig) FilePathJoin(x ...string) string { |
| 77 | if c.GOOS() == "windows" { |
| 78 | return strings.Join(x, "\\") |
| 79 | } |
| 80 | return strings.Join(x, "/") |
| 81 | } |
| 82 | |
| 83 | // BuildletBucket is the GCS storage bucket which holds the buildlet binaries. |
| 84 | // Tools working in the dev project may change this. |
| 85 | var BuildletBucket = "go-builder-data" |
| 86 | |
| 87 | func fixBuildletBucket(u string) string { |
| 88 | if BuildletBucket == "go-builder-data" { |
| 89 | // Prod. Default case. |
| 90 | return u |
| 91 | } |
| 92 | // Dev project remapping: |
| 93 | return strings.Replace(u, |
| 94 | "//storage.googleapis.com/go-builder-data/", |
| 95 | "//storage.googleapis.com/"+BuildletBucket+"/", |
| 96 | 1) |
| 97 | } |
| 98 | |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 99 | // BuildletBinaryURL returns the public URL of this builder's buildlet. |
| 100 | func (c *BuildConfig) BuildletBinaryURL() string { |
| 101 | if c.buildletURL != "" { |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 102 | return fixBuildletBucket(c.buildletURL) |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 103 | } |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 104 | return fixBuildletBucket("http://storage.googleapis.com/go-builder-data/buildlet." + c.GOOS() + "-" + c.GOARCH()) |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 105 | } |
| 106 | |
Andrew Gerrand | 7171600 | 2015-05-18 13:23:24 +1000 | [diff] [blame] | 107 | // SetBuildletBinaryURL sets the public URL of this builder's buildlet. |
| 108 | func (c *BuildConfig) SetBuildletBinaryURL(u string) { |
| 109 | c.buildletURL = u |
| 110 | } |
| 111 | |
Brad Fitzpatrick | a5383ff | 2015-06-17 08:22:14 -0700 | [diff] [blame] | 112 | func (c *BuildConfig) IsRace() bool { |
| 113 | return strings.HasSuffix(c.Name, "-race") |
| 114 | } |
| 115 | |
Brad Fitzpatrick | f8c2484 | 2015-01-16 09:54:03 -0800 | [diff] [blame] | 116 | // AllScript returns the relative path to the operating system's script to |
| 117 | // do the build and run its standard set of tests. |
| 118 | // Example values are "src/all.bash", "src/all.bat", "src/all.rc". |
| 119 | func (c *BuildConfig) AllScript() string { |
Brad Fitzpatrick | a5383ff | 2015-06-17 08:22:14 -0700 | [diff] [blame] | 120 | if c.IsRace() { |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 121 | if strings.HasPrefix(c.Name, "windows-") { |
| 122 | return "src/race.bat" |
| 123 | } |
| 124 | return "src/race.bash" |
| 125 | } |
Brad Fitzpatrick | f8c2484 | 2015-01-16 09:54:03 -0800 | [diff] [blame] | 126 | if strings.HasPrefix(c.Name, "windows-") { |
| 127 | return "src/all.bat" |
| 128 | } |
| 129 | if strings.HasPrefix(c.Name, "plan9-") { |
| 130 | return "src/all.rc" |
| 131 | } |
Brad Fitzpatrick | 0e84fc7 | 2015-02-18 14:12:22 -0800 | [diff] [blame] | 132 | if strings.HasPrefix(c.Name, "nacl-") { |
| 133 | return "src/nacltest.bash" |
| 134 | } |
David Crawshaw | 953e869 | 2015-09-03 13:35:10 -0400 | [diff] [blame] | 135 | if strings.HasPrefix(c.Name, "android-") { |
| 136 | return "src/androidtest.bash" |
| 137 | } |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 138 | if strings.HasPrefix(c.Name, "darwin-arm") { |
| 139 | return "src/iostest.bash" |
| 140 | } |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 141 | if c.Name == "misc-compile" { |
Brad Fitzpatrick | ab7ff8a | 2015-04-29 14:44:46 -0700 | [diff] [blame] | 142 | return "src/buildall.bash" |
| 143 | } |
Brad Fitzpatrick | f8c2484 | 2015-01-16 09:54:03 -0800 | [diff] [blame] | 144 | return "src/all.bash" |
| 145 | } |
| 146 | |
Brad Fitzpatrick | 7d9b036 | 2015-05-27 11:51:27 -0700 | [diff] [blame] | 147 | // SplitMakeRun reports whether the coordinator should first compile |
| 148 | // (using c.MakeScript), then snapshot, then run the tests (ideally |
| 149 | // sharded) using c.RunScript. |
| 150 | // Eventually this function should always return true (and then be deleted) |
| 151 | // but for now we've only set up the scripts and verified that the main |
| 152 | // configurations work. |
| 153 | func (c *BuildConfig) SplitMakeRun() bool { |
| 154 | switch c.AllScript() { |
Brad Fitzpatrick | a5383ff | 2015-06-17 08:22:14 -0700 | [diff] [blame] | 155 | case "src/all.bash", "src/race.bash", "src/all.bat", "src/all.rc": |
Brad Fitzpatrick | 7d9b036 | 2015-05-27 11:51:27 -0700 | [diff] [blame] | 156 | // These we've verified to work. |
| 157 | return true |
| 158 | } |
| 159 | // Conservatively: |
| 160 | return false |
| 161 | } |
| 162 | |
Andrew Gerrand | 234725b | 2015-06-04 16:45:17 -0700 | [diff] [blame] | 163 | func (c *BuildConfig) BuildSubrepos() bool { |
| 164 | if !c.SplitMakeRun() { |
| 165 | return false |
| 166 | } |
Andrew Gerrand | af7d181 | 2015-06-11 10:01:24 -0700 | [diff] [blame] | 167 | // TODO(adg,bradfitz): expand this as required |
| 168 | switch c.Name { |
| 169 | case "darwin-amd64-10_10", |
| 170 | "freebsd-386-gce101", "freebsd-amd64-gce101", |
| 171 | "linux-386", "linux-amd64", "linux-amd64-nocgo", |
| 172 | "openbsd-386-gce56", "openbsd-amd64-gce56", |
| 173 | "plan9-386", |
| 174 | "windows-386-gce", "windows-amd64-gce": |
| 175 | return true |
| 176 | default: |
| 177 | return false |
| 178 | } |
Andrew Gerrand | 234725b | 2015-06-04 16:45:17 -0700 | [diff] [blame] | 179 | } |
| 180 | |
Andrew Gerrand | fb77488 | 2015-05-21 14:02:38 +1000 | [diff] [blame] | 181 | // AllScriptArgs returns the set of arguments that should be passed to the |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 182 | // all.bash-equivalent script. Usually empty. |
| 183 | func (c *BuildConfig) AllScriptArgs() []string { |
| 184 | if strings.HasPrefix(c.Name, "darwin-arm") { |
| 185 | return []string{"-restart"} |
| 186 | } |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 187 | return append([]string(nil), c.allScriptArgs...) |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 188 | } |
| 189 | |
Andrew Gerrand | f83f3e4 | 2015-02-02 12:05:01 +0000 | [diff] [blame] | 190 | // MakeScript returns the relative path to the operating system's script to |
| 191 | // do the build. |
| 192 | // Example values are "src/make.bash", "src/make.bat", "src/make.rc". |
| 193 | func (c *BuildConfig) MakeScript() string { |
| 194 | if strings.HasPrefix(c.Name, "windows-") { |
| 195 | return "src/make.bat" |
| 196 | } |
| 197 | if strings.HasPrefix(c.Name, "plan9-") { |
| 198 | return "src/make.rc" |
| 199 | } |
| 200 | return "src/make.bash" |
| 201 | } |
| 202 | |
Andrew Gerrand | fb77488 | 2015-05-21 14:02:38 +1000 | [diff] [blame] | 203 | // MakeScriptArgs returns the set of arguments that should be passed to the |
| 204 | // make.bash-equivalent script. Usually empty. |
| 205 | func (c *BuildConfig) MakeScriptArgs() []string { |
| 206 | return c.AllScriptArgs() |
| 207 | } |
| 208 | |
| 209 | // RunScript returns the relative path to the operating system's script to |
| 210 | // run the test suite. |
| 211 | // Example values are "src/run.bash", "src/run.bat", "src/run.rc". |
| 212 | func (c *BuildConfig) RunScript() string { |
| 213 | if strings.HasPrefix(c.Name, "windows-") { |
| 214 | return "src/run.bat" |
| 215 | } |
| 216 | if strings.HasPrefix(c.Name, "plan9-") { |
| 217 | return "src/run.rc" |
| 218 | } |
| 219 | return "src/run.bash" |
| 220 | } |
| 221 | |
| 222 | // RunScriptArgs returns the set of arguments that should be passed to the |
| 223 | // run.bash-equivalent script. |
| 224 | func (c *BuildConfig) RunScriptArgs() []string { |
| 225 | return []string{"--no-rebuild"} |
| 226 | } |
| 227 | |
Andrew Gerrand | f83f3e4 | 2015-02-02 12:05:01 +0000 | [diff] [blame] | 228 | // GorootFinal returns the default install location for |
| 229 | // releases for this platform. |
| 230 | func (c *BuildConfig) GorootFinal() string { |
| 231 | if strings.HasPrefix(c.Name, "windows-") { |
| 232 | return "c:\\go" |
| 233 | } |
| 234 | return "/usr/local/go" |
| 235 | } |
| 236 | |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 237 | // MachineType returns the GCE machine type to use for this builder. |
| 238 | func (c *BuildConfig) MachineType() string { |
| 239 | if v := c.machineType; v != "" { |
| 240 | return v |
| 241 | } |
| 242 | return "n1-highcpu-2" |
| 243 | } |
| 244 | |
David Crawshaw | eef380f | 2015-04-30 20:03:01 -0400 | [diff] [blame] | 245 | // ShortOwner returns a short human-readable owner. |
| 246 | func (c BuildConfig) ShortOwner() string { |
| 247 | if c.Owner == "" { |
| 248 | return "go-dev" |
| 249 | } |
| 250 | return strings.TrimSuffix(c.Owner, "@golang.org") |
| 251 | } |
| 252 | |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 253 | // GCENumCPU reports the number of GCE CPUs this buildlet requires. |
| 254 | func (c *BuildConfig) GCENumCPU() int { |
| 255 | t := c.MachineType() |
| 256 | n, _ := strconv.Atoi(t[strings.LastIndex(t, "-")+1:]) |
| 257 | return n |
| 258 | } |
| 259 | |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 260 | func init() { |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 261 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 262 | Name: "freebsd-amd64-gce93", |
| 263 | VMImage: "freebsd-amd64-gce93", |
| 264 | machineType: "n1-highcpu-2", |
| 265 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-freebsd-amd64.tar.gz", |
| 266 | NumTestHelpers: 3, |
Bill Thiede | 222a9c0 | 2015-01-21 21:16:54 -0800 | [diff] [blame] | 267 | }) |
| 268 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 269 | Name: "freebsd-amd64-gce101", |
| 270 | Notes: "FreeBSD 10.1; GCE VM is built from script in build/env/freebsd-amd64", |
| 271 | VMImage: "freebsd-amd64-gce101", |
| 272 | machineType: "n1-highcpu-2", |
| 273 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-freebsd-amd64.tar.gz", |
| 274 | env: []string{"CC=clang"}, |
| 275 | NumTestHelpers: 3, |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 276 | }) |
| 277 | addBuilder(BuildConfig{ |
| 278 | Name: "freebsd-amd64-race", |
| 279 | VMImage: "freebsd-amd64-gce101", |
| 280 | machineType: "n1-highcpu-4", |
| 281 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-freebsd-amd64.tar.gz", |
| 282 | env: []string{"CC=clang"}, |
| 283 | }) |
| 284 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 285 | Name: "freebsd-386-gce101", |
| 286 | VMImage: "freebsd-amd64-gce101", |
| 287 | //BuildletType: "freebsd-amd64-gce101", |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 288 | machineType: "n1-highcpu-2", |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 289 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.freebsd-amd64", |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 290 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-freebsd-amd64.tar.gz", |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 291 | // TODO(bradfitz): setting GOHOSTARCH=386 should work |
| 292 | // to eliminate some unnecessary work (it works on |
| 293 | // Linux), but fails on FreeBSD with: |
| 294 | // ##### ../misc/cgo/testso |
| 295 | // Shared object "libcgosotest.so" not found, required by "main" |
| 296 | // Maybe this is a clang thing? We'll see when we do linux clang too. |
Brad Fitzpatrick | 1288e66 | 2015-09-24 18:19:32 +0200 | [diff] [blame] | 297 | env: []string{"GOARCH=386", "CC=clang"}, |
| 298 | NumTestHelpers: 3, |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 299 | }) |
| 300 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 301 | Name: "linux-386", |
| 302 | VMImage: "linux-buildlet-std", |
| 303 | //BuildletType: "linux-amd64", |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 304 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 305 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GOARCH=386", "GOHOSTARCH=386"}, |
| 306 | NumTestHelpers: 3, |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 307 | }) |
| 308 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 309 | Name: "linux-386-387", |
| 310 | Notes: "GO386=387", |
| 311 | VMImage: "linux-buildlet-std", |
| 312 | //BuildletType: "linux-amd64", |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 313 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 314 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GOARCH=386", "GOHOSTARCH=386", "GO386=387"}, |
| 315 | }) |
| 316 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 317 | Name: "linux-amd64", |
| 318 | VMImage: "linux-buildlet-std", |
| 319 | env: []string{"GOROOT_BOOTSTRAP=/go1.4"}, |
| 320 | NumTestHelpers: 3, |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 321 | }) |
| 322 | addBuilder(BuildConfig{ |
Evan Brown | 08b68a9 | 2015-11-20 10:00:06 -0800 | [diff] [blame^] | 323 | Name: "linux-amd64-kube", |
| 324 | KubeImage: "linux-x86-std:latest", |
| 325 | env: []string{"GOROOT_BOOTSTRAP=/go1.4"}, |
| 326 | NumTestHelpers: 3, |
| 327 | }) |
| 328 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 329 | Name: "misc-compile", |
| 330 | TryOnly: true, |
Brad Fitzpatrick | ab7ff8a | 2015-04-29 14:44:46 -0700 | [diff] [blame] | 331 | VMImage: "linux-buildlet-std", |
Brad Fitzpatrick | 6bf0fc4 | 2015-04-30 11:13:20 -0700 | [diff] [blame] | 332 | machineType: "n1-highcpu-16", // CPU-bound, uses it well. |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 333 | Notes: "Runs buildall.sh to compile stdlib for GOOS/GOARCH pairs not otherwise covered by trybots, but doesn't run any tests.", |
Brad Fitzpatrick | ab7ff8a | 2015-04-29 14:44:46 -0700 | [diff] [blame] | 334 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 335 | env: []string{"GOROOT_BOOTSTRAP=/go1.4"}, |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 336 | allScriptArgs: []string{ |
| 337 | // Filtering pattern to buildall.bash: |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 338 | "^(linux-arm64|linux-ppc64|linux-ppc64le|nacl-arm|plan9-amd64|solaris-amd64|netbsd-386|netbsd-amd64|netbsd-arm|freebsd-arm|darwin-386)$", |
| 339 | }, |
Brad Fitzpatrick | ab7ff8a | 2015-04-29 14:44:46 -0700 | [diff] [blame] | 340 | }) |
| 341 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 342 | Name: "linux-amd64-nocgo", |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 343 | Notes: "cgo disabled", |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 344 | VMImage: "linux-buildlet-std", |
| 345 | env: []string{ |
| 346 | "GOROOT_BOOTSTRAP=/go1.4", |
| 347 | "CGO_ENABLED=0", |
| 348 | // This USER=root was required for Docker-based builds but probably isn't required |
| 349 | // in the VM anymore, since the buildlet probably already has this in its environment. |
| 350 | // (It was required because without cgo, it couldn't find the username) |
| 351 | "USER=root", |
| 352 | }, |
| 353 | }) |
| 354 | addBuilder(BuildConfig{ |
| 355 | Name: "linux-amd64-noopt", |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 356 | Notes: "optimizations and inlining disabled", |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 357 | VMImage: "linux-buildlet-std", |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 358 | //BuildletType: "linux-amd64", |
| 359 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GO_GCFLAGS=-N -l"}, |
Brad Fitzpatrick | 50ba0cb | 2015-01-27 14:22:21 -0800 | [diff] [blame] | 360 | }) |
| 361 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | a5383ff | 2015-06-17 08:22:14 -0700 | [diff] [blame] | 362 | Name: "linux-amd64-race", |
| 363 | VMImage: "linux-buildlet-std", |
| 364 | machineType: "n1-highcpu-4", |
| 365 | env: []string{"GOROOT_BOOTSTRAP=/go1.4"}, |
| 366 | NumTestHelpers: 4, |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 367 | }) |
| 368 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 369 | Name: "linux-386-clang", |
| 370 | VMImage: "linux-buildlet-clang", |
| 371 | //BuildletType: "linux-amd64-clang", |
Brad Fitzpatrick | a0a155e | 2015-02-12 19:45:02 -0800 | [diff] [blame] | 372 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
Brad Fitzpatrick | 4d7595c | 2015-02-13 16:32:21 -0800 | [diff] [blame] | 373 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "CC=/usr/bin/clang", "GOHOSTARCH=386"}, |
Brad Fitzpatrick | a0a155e | 2015-02-12 19:45:02 -0800 | [diff] [blame] | 374 | }) |
| 375 | addBuilder(BuildConfig{ |
| 376 | Name: "linux-amd64-clang", |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 377 | Notes: "Debian wheezy + clang 3.5 instead of gcc", |
Brad Fitzpatrick | a0a155e | 2015-02-12 19:45:02 -0800 | [diff] [blame] | 378 | VMImage: "linux-buildlet-clang", |
| 379 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "CC=/usr/bin/clang"}, |
| 380 | }) |
| 381 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | f0728e3 | 2015-02-13 19:01:32 -0800 | [diff] [blame] | 382 | Name: "linux-386-sid", |
| 383 | VMImage: "linux-buildlet-sid", |
| 384 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 385 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GOHOSTARCH=386"}, |
| 386 | }) |
| 387 | addBuilder(BuildConfig{ |
| 388 | Name: "linux-amd64-sid", |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 389 | Notes: "Debian sid (unstable)", |
Brad Fitzpatrick | f0728e3 | 2015-02-13 19:01:32 -0800 | [diff] [blame] | 390 | VMImage: "linux-buildlet-sid", |
| 391 | env: []string{"GOROOT_BOOTSTRAP=/go1.4"}, |
| 392 | }) |
| 393 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1f0d8f2 | 2015-09-14 18:33:55 +0000 | [diff] [blame] | 394 | Name: "linux-arm", |
| 395 | IsReverse: true, |
| 396 | NumTestHelpers: 6, |
| 397 | env: []string{"GOROOT_BOOTSTRAP=/usr/local/go"}, |
Brad Fitzpatrick | dfe8286 | 2015-03-01 09:23:57 -0800 | [diff] [blame] | 398 | }) |
| 399 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | f319bb6 | 2015-05-07 11:36:25 -0700 | [diff] [blame] | 400 | Name: "linux-arm-arm5", |
| 401 | IsReverse: true, |
Brad Fitzpatrick | 1c43756 | 2015-05-11 08:47:37 -0700 | [diff] [blame] | 402 | env: []string{ |
| 403 | "GOROOT_BOOTSTRAP=/usr/local/go", |
Brad Fitzpatrick | bab0718 | 2015-05-13 15:16:31 -0700 | [diff] [blame] | 404 | "GOARM=5", |
Brad Fitzpatrick | 1c43756 | 2015-05-11 08:47:37 -0700 | [diff] [blame] | 405 | "GO_TEST_TIMEOUT_SCALE=5", // slow. |
| 406 | }, |
Brad Fitzpatrick | f319bb6 | 2015-05-07 11:36:25 -0700 | [diff] [blame] | 407 | }) |
| 408 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 0e84fc7 | 2015-02-18 14:12:22 -0800 | [diff] [blame] | 409 | Name: "nacl-386", |
Brad Fitzpatrick | 38c2c75 | 2015-03-24 18:50:33 -0700 | [diff] [blame] | 410 | VMImage: "linux-buildlet-nacl-v2", |
Brad Fitzpatrick | 0e84fc7 | 2015-02-18 14:12:22 -0800 | [diff] [blame] | 411 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 412 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GOOS=nacl", "GOARCH=386", "GOHOSTOS=linux", "GOHOSTARCH=amd64"}, |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 413 | //BuildletType: "nacl-amd64p32", |
Brad Fitzpatrick | 0e84fc7 | 2015-02-18 14:12:22 -0800 | [diff] [blame] | 414 | }) |
| 415 | addBuilder(BuildConfig{ |
| 416 | Name: "nacl-amd64p32", |
Brad Fitzpatrick | 38c2c75 | 2015-03-24 18:50:33 -0700 | [diff] [blame] | 417 | VMImage: "linux-buildlet-nacl-v2", |
Brad Fitzpatrick | 0e84fc7 | 2015-02-18 14:12:22 -0800 | [diff] [blame] | 418 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.linux-amd64", |
| 419 | env: []string{"GOROOT_BOOTSTRAP=/go1.4", "GOOS=nacl", "GOARCH=amd64p32", "GOHOSTOS=linux", "GOHOSTARCH=amd64"}, |
| 420 | }) |
| 421 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 422 | Name: "openbsd-amd64-gce56", |
| 423 | Notes: "OpenBSD 5.6; GCE VM is built from script in build/env/openbsd-amd64", |
| 424 | VMImage: "openbsd-amd64-56", |
| 425 | machineType: "n1-highcpu-2", |
| 426 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-openbsd-amd64.tar.gz", |
| 427 | NumTestHelpers: 3, |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 428 | }) |
| 429 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 430 | Name: "openbsd-386-gce56", |
| 431 | Notes: "OpenBSD 5.6; GCE VM is built from script in build/env/openbsd-386", |
| 432 | VMImage: "openbsd-386-56", |
| 433 | machineType: "n1-highcpu-2", |
| 434 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-openbsd-386.tar.gz", |
| 435 | NumTestHelpers: 3, |
Brad Fitzpatrick | f6a4a4a | 2015-01-22 14:11:10 -0800 | [diff] [blame] | 436 | }) |
| 437 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 438 | Name: "plan9-386", |
| 439 | Notes: "Plan 9 from 0intro; GCE VM is built from script in build/env/plan9-386", |
Brad Fitzpatrick | dfe8286 | 2015-03-01 09:23:57 -0800 | [diff] [blame] | 440 | VMImage: "plan9-386-v2", |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 441 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-plan9-386.tar.gz", |
Brad Fitzpatrick | 32d0520 | 2015-01-21 15:15:48 -0800 | [diff] [blame] | 442 | |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 443 | // We *were* using n1-standard-1 because Plan 9 can only |
| 444 | // reliably use a single CPU. Using 2 or 4 and we see |
| 445 | // test failures. See: |
| 446 | // https://golang.org/issue/8393 |
| 447 | // https://golang.org/issue/9491 |
Brad Fitzpatrick | dfe8286 | 2015-03-01 09:23:57 -0800 | [diff] [blame] | 448 | // n1-standard-1 has 3.6 GB of memory which WAS (see below) |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 449 | // overkill (userspace probably only sees 2GB anyway), |
| 450 | // but it's the cheapest option. And plenty to keep |
| 451 | // our ~250 MB of inputs+outputs in its ramfs. |
| 452 | // |
| 453 | // But the docs says "For the n1 series of machine |
| 454 | // types, a virtual CPU is implemented as a single |
| 455 | // hyperthread on a 2.6GHz Intel Sandy Bridge Xeon or |
| 456 | // Intel Ivy Bridge Xeon (or newer) processor. This |
| 457 | // means that the n1-standard-2 machine type will see |
| 458 | // a whole physical core." |
| 459 | // |
Brad Fitzpatrick | dfe8286 | 2015-03-01 09:23:57 -0800 | [diff] [blame] | 460 | // ... so we used n1-highcpu-2 (1.80 RAM, still |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 461 | // plenty), just so we can get 1 whole core for the |
| 462 | // single-core Plan 9. It will see 2 virtual cores and |
| 463 | // only use 1, but we hope that 1 will be more powerful |
| 464 | // and we'll stop timing out on tests. |
David du Colombier | 6ff9135 | 2015-08-05 13:52:50 +0200 | [diff] [blame] | 465 | machineType: "n1-highcpu-4", |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 466 | |
| 467 | NumTestHelpers: 5, // slow |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 468 | }) |
Brad Fitzpatrick | cc587d4 | 2015-02-06 17:32:15 -0800 | [diff] [blame] | 469 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 470 | Name: "windows-amd64-gce", |
| 471 | VMImage: "windows-buildlet-v2", |
| 472 | machineType: "n1-highcpu-2", |
| 473 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-windows-amd64.tar.gz", |
| 474 | RegularDisk: true, |
| 475 | env: []string{"GOARCH=amd64", "GOHOSTARCH=amd64"}, |
| 476 | NumTestHelpers: 3, |
Brad Fitzpatrick | cc587d4 | 2015-02-06 17:32:15 -0800 | [diff] [blame] | 477 | }) |
| 478 | addBuilder(BuildConfig{ |
| 479 | Name: "windows-amd64-race", |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 480 | Notes: "Only runs -race tests (./race.bat)", |
Brad Fitzpatrick | 0c0bd36 | 2015-03-22 10:50:04 -0700 | [diff] [blame] | 481 | VMImage: "windows-buildlet-v2", |
Brad Fitzpatrick | cc587d4 | 2015-02-06 17:32:15 -0800 | [diff] [blame] | 482 | machineType: "n1-highcpu-4", |
| 483 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-windows-amd64.tar.gz", |
Brad Fitzpatrick | 1c6d916 | 2015-03-20 16:14:52 -0700 | [diff] [blame] | 484 | RegularDisk: true, |
Brad Fitzpatrick | cc587d4 | 2015-02-06 17:32:15 -0800 | [diff] [blame] | 485 | env: []string{"GOARCH=amd64", "GOHOSTARCH=amd64"}, |
| 486 | }) |
| 487 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 1b1e086 | 2015-06-04 18:25:50 -0700 | [diff] [blame] | 488 | Name: "windows-386-gce", |
| 489 | VMImage: "windows-buildlet-v2", |
| 490 | machineType: "n1-highcpu-2", |
| 491 | // TODO(bradfitz): once buildlet type vs. config type is split: BuildletType: "windows-amd64-gce", |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 492 | buildletURL: "http://storage.googleapis.com/go-builder-data/buildlet.windows-amd64", |
| 493 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-windows-386.tar.gz", |
| 494 | RegularDisk: true, |
| 495 | env: []string{"GOARCH=386", "GOHOSTARCH=386"}, |
| 496 | NumTestHelpers: 3, |
Brad Fitzpatrick | cc587d4 | 2015-02-06 17:32:15 -0800 | [diff] [blame] | 497 | }) |
David Crawshaw | 66c36dd | 2015-04-23 10:23:22 -0400 | [diff] [blame] | 498 | addBuilder(BuildConfig{ |
Brad Fitzpatrick | 79f3fc0 | 2015-05-27 21:51:25 -0700 | [diff] [blame] | 499 | Name: "darwin-amd64-10_10", |
| 500 | Notes: "Mac Mini running OS X 10.10 (Yosemite)", |
| 501 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 502 | IsReverse: true, |
Brad Fitzpatrick | efae87d | 2015-10-28 17:41:06 +0000 | [diff] [blame] | 503 | NumTestHelpers: 0, // disabled per golang.org/issue/12979 |
David Crawshaw | 66c36dd | 2015-04-23 10:23:22 -0400 | [diff] [blame] | 504 | }) |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 505 | addBuilder(BuildConfig{ |
David Crawshaw | e29c0bb | 2015-07-22 10:54:18 -0400 | [diff] [blame] | 506 | Name: "darwin-386-10_10", |
| 507 | Notes: "Mac Mini running OS X 10.10 (Yosemite)", |
| 508 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 509 | IsReverse: true, |
| 510 | env: []string{"GOARCH=386"}, |
Brad Fitzpatrick | efae87d | 2015-10-28 17:41:06 +0000 | [diff] [blame] | 511 | NumTestHelpers: 0, // disabled per golang.org/issue/12979 |
David Crawshaw | e29c0bb | 2015-07-22 10:54:18 -0400 | [diff] [blame] | 512 | }) |
| 513 | addBuilder(BuildConfig{ |
| 514 | Name: "android-arm-sdk19", |
| 515 | Notes: "Android ARM device running android-19 (KitKat 4.4), attatched to Mac Mini", |
| 516 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 517 | IsReverse: true, |
| 518 | env: []string{"GOOS=android", "GOARCH=arm"}, |
| 519 | NumTestHelpers: 1, // limited resources |
| 520 | }) |
| 521 | addBuilder(BuildConfig{ |
David Crawshaw | 1a1fe1e | 2015-11-20 11:08:04 -0500 | [diff] [blame] | 522 | Name: "android-arm64-sdk21", |
| 523 | Notes: "Android arm64 device using the android-21 toolchain, attatched to Mac Mini", |
| 524 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 525 | IsReverse: true, |
| 526 | env: []string{"GOOS=android", "GOARCH=arm64"}, |
| 527 | NumTestHelpers: 1, // limited resources |
| 528 | }) |
| 529 | addBuilder(BuildConfig{ |
| 530 | Name: "android-386-sdk21", |
| 531 | Notes: "Android 386 device using the android-21 toolchain, attatched to Mac Mini", |
| 532 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 533 | IsReverse: true, |
| 534 | env: []string{"GOOS=android", "GOARCH=386"}, |
| 535 | NumTestHelpers: 1, // limited resources |
| 536 | }) |
| 537 | addBuilder(BuildConfig{ |
| 538 | Name: "android-amd64-sdk21", |
| 539 | Notes: "Android amd64 device using the android-21 toolchain, attatched to Mac Mini", |
| 540 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 541 | IsReverse: true, |
| 542 | env: []string{"GOOS=android", "GOARCH=amd64"}, |
| 543 | NumTestHelpers: 1, // limited resources |
| 544 | }) |
| 545 | addBuilder(BuildConfig{ |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 546 | Name: "darwin-arm-a5ios", |
| 547 | Notes: "iPhone 4S (A5 processor), via a Mac Mini", |
| 548 | Owner: "crawshaw@golang.org", |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 549 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 550 | IsReverse: true, |
| 551 | env: []string{"GOARCH=arm", "GOHOSTARCH=amd64"}, |
| 552 | }) |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 553 | addBuilder(BuildConfig{ |
David Crawshaw | 2c91215 | 2015-04-29 11:27:26 -0400 | [diff] [blame] | 554 | Name: "darwin-arm64-a7ios", |
| 555 | Notes: "iPad Mini 3 (A7 processor), via a Mac Mini", |
| 556 | Owner: "crawshaw@golang.org", |
David Crawshaw | e078c6f | 2015-04-29 08:54:19 -0400 | [diff] [blame] | 557 | Go14URL: "https://storage.googleapis.com/go-builder-data/go1.4-darwin-amd64.tar.gz", |
| 558 | IsReverse: true, |
| 559 | env: []string{"GOARCH=arm64", "GOHOSTARCH=amd64"}, |
| 560 | }) |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 561 | } |
| 562 | |
| 563 | func addBuilder(c BuildConfig) { |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 564 | if c.Name == "" { |
| 565 | panic("empty name") |
| 566 | } |
| 567 | if _, dup := Builders[c.Name]; dup { |
| 568 | panic("dup name") |
| 569 | } |
Brad Fitzpatrick | 3cd1723 | 2015-10-01 22:07:22 +0000 | [diff] [blame] | 570 | if (c.VMImage == "" && c.KubeImage == "") && !c.IsReverse { |
| 571 | panic("empty VMImage and KubeImage on non-reverse builder") |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 572 | } |
Brad Fitzpatrick | 6925ce8 | 2015-09-08 15:18:47 -0700 | [diff] [blame] | 573 | if c.VMImage != "" && c.KubeImage != "" { |
| 574 | panic("there can be only one of VMImage/KubeImage") |
| 575 | } |
Brad Fitzpatrick | 46cc759 | 2015-01-15 12:46:22 -0800 | [diff] [blame] | 576 | Builders[c.Name] = c |
| 577 | } |