| commit | eb48d3f608bba06c3bb4f5627f9fc2562cc84dd2 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Sun Jan 31 15:13:38 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Tue Mar 02 01:39:17 2021 +0000 |
| tree | 34715b7a583f87f61085f3cc8f1532386b4c129e | |
| parent | 7a079fcd7976efee71404a62f2b2be0bbc34f3a5 [diff] |
internal/lsp/cache: refactor diagnostic suppression In typeCheckDiagnostics, we have logic to suppress go list and type checking errors based on the presence of other errors. Nobody seems to know why the logic is exactly what it is, and suppressing list errors means that bad //go:embed patterns don't show up. Intuitively, it makes sense to me that we don't want to type check if listing or parsing fails: list errors mean that whole files may be missing, and parsing errors may wipe out arbitrary chunks of files. There's little point reporting errors from type checking that. However, list errors and parse errors should be mostly orthogonal: go list parses very little of the file and in practice only reports errors parsing the package statement. So, at least for now, we report both parse and list errors, and stop there if there are any. Finally, move the suppression logic to the actual typeCheck function that generates the diagnostics. typeCheckDiagnostics is the primary consumer, but I think it's better to do the suppression at the source. Because we are now showing list errors, and they are prone to getting stuck due to bad overlay support, a couple of tests now require 1.16. Change-Id: I7801e44c4d3da30bda61e0c1710a2f52de6215f5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/295414 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.