| commit | 7a079fcd7976efee71404a62f2b2be0bbc34f3a5 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Fri Feb 19 16:30:51 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Mon Mar 01 19:05:15 2021 +0000 |
| tree | 1f2d71bee7ca48ec09eb3b5864a3cad0251c3671 | |
| parent | f5a4005dda57a682af872b31ea2ae6999aa44971 [diff] |
internal/lsp/cache: fix related error processing Due to misuse of the expandErrors function, when we encountered a continuing error, we would group all the related errors into a single one, then return both it and all its secondaries individually. That makes for a strange user experience where you get one complete error and N-1 incomplete ones. Instead, create a copy of the complete error for each secondary error, moving the copy to the location of the secondary error and adding a bit to the text to (hopefully) clarify what's going on. Change-Id: I87cf0e3b2cea98317f650d16a78476edf108a934 Reviewed-on: https://go-review.googlesource.com/c/tools/+/295413 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.