)]}'
{
  "commit": "eb48d3f608bba06c3bb4f5627f9fc2562cc84dd2",
  "tree": "34715b7a583f87f61085f3cc8f1532386b4c129e",
  "parents": [
    "7a079fcd7976efee71404a62f2b2be0bbc34f3a5"
  ],
  "author": {
    "name": "Heschi Kreinick",
    "email": "heschi@google.com",
    "time": "Sun Jan 31 15:13:38 2021 -0500"
  },
  "committer": {
    "name": "Heschi Kreinick",
    "email": "heschi@google.com",
    "time": "Tue Mar 02 01:39:17 2021 +0000"
  },
  "message": "internal/lsp/cache: refactor diagnostic suppression\n\nIn typeCheckDiagnostics, we have logic to suppress go list and type\nchecking errors based on the presence of other errors. Nobody seems to\nknow why the logic is exactly what it is, and suppressing list errors\nmeans that bad //go:embed patterns don\u0027t show up.\n\nIntuitively, it makes sense to me that we don\u0027t want to type check if\nlisting or parsing fails: list errors mean that whole files may be\nmissing, and parsing errors may wipe out arbitrary chunks of files.\nThere\u0027s little point reporting errors from type checking that. However,\nlist errors and parse errors should be mostly orthogonal: go list\nparses very little of the file and in practice only reports errors\nparsing the package statement. So, at least for now, we report both\nparse and list errors, and stop there if there are any.\n\nFinally, move the suppression logic to the actual typeCheck function\nthat generates the diagnostics. typeCheckDiagnostics is the primary\nconsumer, but I think it\u0027s better to do the suppression at the source.\n\nBecause we are now showing list errors, and they are prone to getting\nstuck due to bad overlay support, a couple of tests now require 1.16.\n\nChange-Id: I7801e44c4d3da30bda61e0c1710a2f52de6215f5\nReviewed-on: https://go-review.googlesource.com/c/tools/+/295414\nTrust: Heschi Kreinick \u003cheschi@google.com\u003e\nRun-TryBot: Heschi Kreinick \u003cheschi@google.com\u003e\ngopls-CI: kokoro \u003cnoreply+kokoro@google.com\u003e\nTryBot-Result: Go Bot \u003cgobot@golang.org\u003e\nReviewed-by: Robert Findley \u003crfindley@google.com\u003e\nReviewed-by: Rebecca Stambler \u003crstambler@golang.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d6ff75d86bef723dedb0d901bdbb80cb94cc8116",
      "old_mode": 33188,
      "old_path": "go/packages/golist.go",
      "new_id": "0e1e7f11fee8c102578eb752d48bccf676adb821",
      "new_mode": 33188,
      "new_path": "go/packages/golist.go"
    },
    {
      "type": "modify",
      "old_id": "9a2cce85e0b701a1815a60c67fe4efaffa828edc",
      "old_mode": 33188,
      "old_path": "gopls/internal/regtest/codelens/codelens_test.go",
      "new_id": "88d0e047bcdda049fabbe626b2ec74b658a9b585",
      "new_mode": 33188,
      "new_path": "gopls/internal/regtest/codelens/codelens_test.go"
    },
    {
      "type": "modify",
      "old_id": "84b8b3dba287229fac62185426498cb679092a77",
      "old_mode": 33188,
      "old_path": "gopls/internal/regtest/diagnostics/diagnostics_test.go",
      "new_id": "49860005c72f66c0415022499859fccca7abf083",
      "new_mode": 33188,
      "new_path": "gopls/internal/regtest/diagnostics/diagnostics_test.go"
    },
    {
      "type": "modify",
      "old_id": "0c50d610ebe7905ab7c6c821f1859855a4a9e323",
      "old_mode": 33188,
      "old_path": "internal/lsp/cache/check.go",
      "new_id": "e0c7cee0bd473db4753a0bdafcd34aa9098dc75c",
      "new_mode": 33188,
      "new_path": "internal/lsp/cache/check.go"
    },
    {
      "type": "modify",
      "old_id": "8914d0dc04aefb7cda73534bd299b2f13bc9adb7",
      "old_mode": 33188,
      "old_path": "internal/lsp/cache/load.go",
      "new_id": "f958a560630ed2c8da0fdf47ea03b9c37ac36a91",
      "new_mode": 33188,
      "new_path": "internal/lsp/cache/load.go"
    },
    {
      "type": "modify",
      "old_id": "66f3e1a21f81b0304c252bdaed4930c494dc4c18",
      "old_mode": 33188,
      "old_path": "internal/lsp/cache/pkg.go",
      "new_id": "5badb33e8eff40fafd58a9960a9cd1adbf20159f",
      "new_mode": 33188,
      "new_path": "internal/lsp/cache/pkg.go"
    },
    {
      "type": "modify",
      "old_id": "59e6070766f33bedf2937e10e38bb1cf0896c616",
      "old_mode": 33188,
      "old_path": "internal/lsp/diagnostics.go",
      "new_id": "479d9484492252ff2795bf45ce6188ee5b370e6e",
      "new_mode": 33188,
      "new_path": "internal/lsp/diagnostics.go"
    },
    {
      "type": "modify",
      "old_id": "f2b382dea6e32dd7f14836520b3e9158dc3a9afd",
      "old_mode": 33188,
      "old_path": "internal/lsp/source/diagnostics.go",
      "new_id": "f9b82de845cb46057a40615fd3f510a4b80d93bd",
      "new_mode": 33188,
      "new_path": "internal/lsp/source/diagnostics.go"
    },
    {
      "type": "modify",
      "old_id": "5c96908ecd8b06bd8e021da3c97c41ba0a011947",
      "old_mode": 33188,
      "old_path": "internal/lsp/source/view.go",
      "new_id": "1d2c01de17f6fdd13bdec13fb1cc77c95ab85c64",
      "new_mode": 33188,
      "new_path": "internal/lsp/source/view.go"
    }
  ]
}