| commit | ee7bd8d9fcb083db23246d62d3d225d48a1c384e | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Tue Aug 22 11:02:26 2023 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue Aug 22 17:35:10 2023 +0000 |
| tree | 0d9d3ab23a4850a501968df76c2d7af25ef561eb | |
| parent | 2d73b4f4b748889055edaf4ad3971c77309fc42b [diff] |
cmd/frontend: fix variable shadowing of redisClient Following CL 514518, the redisClient is always nil, due to a variable shadowing bug. This led to a production outage (golang/go#62210), which was not caught because the staging environment (where push tests run) was not configured to enforce quota. For starters, fix the variable shadowing bug. I looked into adding a failing test, but it seemed intractible without a major refactoring. Change-Id: I0492b2ece49759ebcae397c6600080fc44658f2b Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521835 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jamal Carvalho <jamal@golang.org>
This repository hosts the source code of the pkg.go.dev website, and pkgsite, a documentation server program.
Pkg.go.dev is a website for discovering and evaluating Go packages and modules.
You can check it out at https://pkg.go.dev.
pkgsite program extracts and generates documentation for Go projects.
Example usage:
$ go install golang.org/x/pkgsite/cmd/pkgsite@latest $ cd myproject $ pkgsite -open .
For more information, see the pkgsite documentation.
Pkgsite requires Go 1.19 to run. The last commit that works with Go 1.18 is 9ffe8b928e4fbd3ff7dcf984254629a47f8b6e63. The last commit that works with Go 1.17 is 4d836c6a652cde92f433967680dfd6171a91ec12.
If you want to report a bug or have a feature suggestion, please first check the known issues to see if your issue is already being discussed. If an issue does not already exist, feel free to file an issue.
For answers to frequently asked questions, see pkg.go.dev/about.
You can also chat with us on the #pkgsite Slack channel on the Gophers Slack.
We would love your help!
Our canonical Git repository is located at go.googlesource.com/pkgsite. There is a mirror of the repository at github.com/golang/pkgsite.
To contribute, please read our contributing guide.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.