tree 0d9d3ab23a4850a501968df76c2d7af25ef561eb
parent 2d73b4f4b748889055edaf4ad3971c77309fc42b
author Rob Findley <rfindley@google.com> 1692716546 -0400
committer Robert Findley <rfindley@google.com> 1692725710 +0000

cmd/frontend: fix variable shadowing of redisClient

Following CL 514518, the redisClient is always nil, due to a variable
shadowing bug. This led to a production outage (golang/go#62210), which
was not caught because the staging environment (where push tests run)
was not configured to enforce quota.

For starters, fix the variable shadowing bug. I looked into adding a
failing test, but it seemed intractible without a major refactoring.

Change-Id: I0492b2ece49759ebcae397c6600080fc44658f2b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/521835
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>