| commit | a99e678c47b3c0878a8d813e7e566727163e04fc | [log] [tgz] |
|---|---|---|
| author | Jonathan Amsterdam <jba@google.com> | Fri Feb 05 07:08:47 2021 -0500 |
| committer | Jonathan Amsterdam <jba@google.com> | Fri Feb 05 18:40:43 2021 +0000 |
| tree | cc2e7ab554e22617aa592bdb14bc1bda73f4aa72 | |
| parent | 33309b4d71458819aec570cf448d2cb6c59e045f [diff] |
internal/testing/sample: use UTC for time Use UTC for sample.CommitTime, instead of the local timezone. This avoids time-dependent test failure due to a mismatch between the database's timezone (UTC) and the test runner's local time. As an example, say a developer runs `go test` on a machine in the US Eastern timezone (UTC-5). Consider TestFetchPackageVersionsDetails in internal/frontend/versions_test.go. This test compares commit times from the DB and from the local machine, formatted as date strings. From 7pm (5 hours before the date changes) until midnight, this test will fail because the Eastern day is one less than the UTC day. For instance, at 8pm EST on a Wednesday, it is 1am UTC on a Thursday. After this CL, all times are UTC, so the days will be same. Change-Id: Ia7bfc964c650aebbc6d20be1feda3e61fc8f2449 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/289949 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
Pkg.go.dev is a website for discovering and evaluating Go packages and modules.
You can check it out at https://pkg.go.dev.
Pkg.go.dev launched in November 2019, and is currently under active development by the Go team.
Here's what we are currently working on:
Design updates: We have some design changes planned for pkg.go.dev, to address UX feedback that we have received. You can expect a more cohesive search and navigation experience coming soon. We plan to share these designs for feedback once they are ready.
Godoc.org redirect: Longer term, we are working towards redirecting godoc.org traffic to pkg.go.dev. We know that there are features available on godoc.org that users want to see on pkg.go.dev, and we want to ensure that we address these. We’ve been keeping track of issues related to redirecting godoc.org traffic on Go issue #39144. These issues will be prioritized in the next few months. We also plan to continue improving our license detection algorithm.
Search improvements: We’ll be improving our search experience based on feedback in Go issue #37810, to make it easier for users to find the dependencies they are looking for and make better decisions around which ones to import.
We encourage everyone to begin using pkg.go.dev today for all of their needs and to file feedback! You can redirect all of your requests from godoc.org to pkg.go.dev, by clicking Always use pkg.go.dev at the top of any page on godoc.org.
If you want to report a bug or have a feature suggestion, please first check the known issues to see if your issue is already being discussed. If an issue does not already exist, feel free to file an issue.
For answers to frequently asked questions, see go.dev/about.
You can also chat with us on the #tools slack channel on the Gophers slack.
We would love your help!
Our canonical Git repository is located at go.googlesource.com/pkgsite. There is a mirror of the repository at github.com/golang/pkgsite.
To contribute, please read our contributing guide.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.