tree cc2e7ab554e22617aa592bdb14bc1bda73f4aa72
parent 33309b4d71458819aec570cf448d2cb6c59e045f
author Jonathan Amsterdam <jba@google.com> 1612526927 -0500
committer Jonathan Amsterdam <jba@google.com> 1612550443 +0000

internal/testing/sample: use UTC for time

Use UTC for sample.CommitTime, instead of the local timezone.  This
avoids time-dependent test failure due to a mismatch between the
database's timezone (UTC) and the test runner's local time.

As an example, say a developer runs `go test` on a machine in the US
Eastern timezone (UTC-5). Consider TestFetchPackageVersionsDetails in
internal/frontend/versions_test.go. This test compares commit times
from the DB and from the local machine, formatted as date strings.

From 7pm (5 hours before the date changes) until midnight, this test
will fail because the Eastern day is one less than the UTC day. For
instance, at 8pm EST on a Wednesday, it is 1am UTC on a Thursday.

After this CL, all times are UTC, so the days will be same.

Change-Id: Ia7bfc964c650aebbc6d20be1feda3e61fc8f2449
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/289949
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>