acme/autocert: remove TestRenewFromCache skips
Removes the skips from TestRenewFromCache and
TestRenewFromCacheAlreadyRenewed, which were added due to flakes which
may have been fixed by the renewal timer change.
Updates golang/go#51080
Change-Id: Ib953a24e610e89dfbbea450a4c257c105055ce7e
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/433815
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
diff --git a/acme/autocert/renewal_test.go b/acme/autocert/renewal_test.go
index 460a384..ffe4af2 100644
--- a/acme/autocert/renewal_test.go
+++ b/acme/autocert/renewal_test.go
@@ -8,7 +8,6 @@
"context"
"crypto"
"crypto/ecdsa"
- "runtime"
"testing"
"time"
@@ -43,15 +42,6 @@
}
func TestRenewFromCache(t *testing.T) {
- if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
- // This test was observed to fail frequently in Dial with "connectex: No
- // connection could be made because the target machine actively refused it."
- //
- // Failures started around CL 381715, so it looks to me (bcmills) like an
- // undiagnosed bug in (or exposed by) acmetest.CAServer.
- t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
- }
-
man := testManager(t)
man.RenewBefore = 24 * time.Hour
@@ -137,15 +127,6 @@
}
func TestRenewFromCacheAlreadyRenewed(t *testing.T) {
- if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
- // This test was observed to fail frequently in Dial with "connectex: No
- // connection could be made because the target machine actively refused it."
- //
- // Failures started around CL 381715, so it looks to me (bcmills) like an
- // undiagnosed bug in (or exposed by) acmetest.CAServer.
- t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
- }
-
ca := acmetest.NewCAServer(t).Start()
man := testManager(t)
man.RenewBefore = 24 * time.Hour
