blob: 6e62800961cb26edf88fd750e5e6ecea552d23a7 [file] [log] [blame] [view]
Andrew Gerrand5bc444d2014-12-10 11:35:11 +11001# Introduction
2
3This document is about the policy for adding a new port to the main Go repository. By port we mean an operating system + architecture combination, such as linux/386.
4
5The goal of this policy is to avoid the accumulation of incomplete or broken ports.
6
7# Requirements for a new port
8
9Before any code relating to a port can be added to the main Go repository, the following must all be done:
10
Russ Coxd852cd82020-05-06 14:34:10 -040011 * A proposal must be filed and accepted in which the Go team accepts overall responsibility for having the new port in the core Go tree. In general, each new port carries an upkeep cost separate from the direct maintenance. That cost varies by port, depending on how similar a new port is to existing ones. The cost must be balanced by an overall benefit in the form of potential new users or use cases for Go.
12
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110013 * At least one developer must be named (and agree) to maintain the port, by making required updates in a timely manner as architecture or operating system requirements change.
14
Dmitri Shuralyov8586a8b2019-12-12 12:50:34 -050015 * A developer must be named (and agree) to maintain the builder, the machine trying each git revision and providing data for https://build.golang.org.
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110016
17 * The builder must already be running (and failing, because the code is not yet in the main repository).
18
19 * All CLs necessary to run all.bash successfully must have been sent for review. Typically this will be a handful of CLs split by the part of the tree they change.
20
21Once those conditions are satisfied, the Go team can accept the port and begin to merge the CLs. Once the CLs are all submitted, all.bash must pass, so that the builder reports "ok" in the dashboard.
22
23Any port started during a release cycle must be finished (all.bash passing, builder reporting "ok") before the corresponding release freeze, or else the code will be removed at the freeze.
24
Rob Pikebb274842015-04-01 14:24:32 -070025# Other repositories
26
27Although it is not part of the core repository, the x/sys repository should add support for the new port before the release happens because it is the official place to add new system calls.
28
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110029# First class ports
30
31Some ports are considered "first class". The distinction is mostly about releases and distribution.
32
33A first class port has these properties:
34
35 * Broken builds block releases
36 * All contributors are effectively responsible for these ports (You break it, you fix it, or find someone who can.)
37 * Official binaries are provided
38 * Requires Google's Go team to own the builder machine
Dmitri Shuralyov8586a8b2019-12-12 12:50:34 -050039 * Installation is documented at https://golang.org/doc/install
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110040
41Graduating a port to "first class" is at the discretion of the Go team at Google.
42
Brad Fitzpatrick7b425932017-01-06 13:13:43 -080043The current first class ports are:
44
45* linux/amd64
46* linux/386
47* linux/arm
Brad Fitzpatrick425e4a82019-12-04 12:44:43 -080048* linux/arm64
Brad Fitzpatrick7b425932017-01-06 13:13:43 -080049* darwin/amd64
50* windows/amd64
51* windows/386
52
53We distribute binaries for other GOOS/GOARCH pairs (other "ports"), but they are not "first class" by this definition.
54
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110055# Removing a port
56
57If a builder for a particular port starts failing, the code should be corrected as soon as possible; otherwise future regressions cannot be detected, and the amount of work required to bring the builder back to "ok" compounds.
58
59Ultimately the job of making the port work again falls to the developer maintaining the port, although simple cases (such as +build lines in new code) can and should be fixed by others.
60
61If a builder fails for more than two weeks, it is time to start looking for a more active maintainer for the port.
62
63If a builder fails for more than four weeks or is failing at the time of a release freeze, and a new maintainer cannot be found, the port will be removed from the tree.
64
65Due to backwards compatibility concerns, removing a formerly working port should be a last resort. Finding a new maintainer is always preferable.
66
Brad Fitzpatrick812affa2018-06-20 07:56:56 -070067# Getting started
68
69See https://groups.google.com/forum/#!topic/golang-dev/SRUK7yJVA0c for some discussion on how to go about writing a new port.
70
Andrew Gerrand5bc444d2014-12-10 11:35:11 +110071# Comments and Questions
72
73Comments or questions about the policy should be sent to golang-dev.