commit b8642e1f177a242e775ea27cb1ca4552e6255b82
author Russ Cox <rsc@golang.org> Fri Oct 13 13:13:19 2023 -0400
committer Russ Cox <rsc@golang.org> Thu Nov 09 07:17:35 2023 +0000
tree 57821b3b1f631d3b3ca59fd55e45e39839c79eab
parent a7a2638b0f632cc585cfe65f9dbc0119bf098b9f

_content/doc/codewalk: fix more js problems

The scrolling logic really needs the full page to fit in a browser window.
Do that by hiding the huge footer entirely.
Also fix a bug that was keeping the selected file name from displaying.

Change-Id: I641e7b1de9fc7a512f79e020ecdaa727e67d9810
Reviewed-on: https://go-review.googlesource.com/c/website/+/535275
Reviewed-by: Eli Bendersky <eliben@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

_content/doc/codewalk/codewalk.js

diff --git a/_content/doc/codewalk/codewalk.js b/_content/doc/codewalk/codewalk.js
index 569ea51..477c0ca 100644
--- a/_content/doc/codewalk/codewalk.js
+++ b/_content/doc/codewalk/codewalk.js
@@ -245,6 +245,7 @@
 CodewalkViewer.prototype.changeSelectedComment = function(target) {
   var currentFile = target.find('.comment-link').attr('href');
   if (!currentFile) return;
+  currentFile = currentFile.replaceAll('%2f', '/').replaceAll('/go.dev/', '/');
 
   if (!(this.lastSelected && this.lastSelected.get(0) === target.get(0))) {
     if (this.lastSelected) this.lastSelected.removeClass('selected');
@@ -261,7 +262,7 @@
     }
     var fname = currentFile.match(/(?:select=|fileprint=)\/[^&]+/)[0];
     fname = fname.slice(fname.indexOf('=')+2, fname.length);
-    this.context.find('#code-selector').val(fname);
+    this.context.find('#code-selector').val('/doc/codewalk/?fileprint=/'+fname);
     this.context.find('#prev-comment').toggleClass(
         'disabled', !target.prev().length);
     this.context.find('#next-comment').toggleClass(
@@ -279,12 +280,15 @@
  * after the user changes the window size.
  */
 CodewalkViewer.prototype.updateHeight = function() {
-  var windowHeight = jQuery(window).height() - 5  // GOK
+  /* The new go.dev footer is too big; hide it since we are trying to keep the whole page on the screen. */
+  jQuery('.Footer').hide();
+
+  /* The -30 here work around some margin that seems to be introduced by the browsers. */
+  var windowHeight = jQuery(window).height() - 30
   var areaHeight = windowHeight - this.codeArea.offset().top
-  /* The new go.dev footer is too big to keep on the page, so zero out footerHeight */
-  var footerHeight = 0 /* jQuery('.Site-footer').outerHeight(true) */
+  var footerHeight = jQuery('.Site-footer').outerHeight(true)
   this.commentArea.height(areaHeight - footerHeight - this.context.find('#comment-options').outerHeight(true))
-  var codeHeight = areaHeight - footerHeight - 15  // GOK
+  var codeHeight = areaHeight - footerHeight - 30
   this.codeArea.height(codeHeight)
   this.codeDisplay.height(codeHeight - this.codeDisplay.offset().top + this.codeArea.offset().top);
   this.sizer.height(codeHeight);