commit 69e03a2e34623742bcee04d432bcf64429747273
author Ian Lance Taylor <iant@golang.org> Thu Sep 08 17:14:20 2022 -0700
committer Ian Lance Taylor <iant@golang.org> Wed Sep 14 02:59:29 2022 +0000
tree ab39ecadd3b8cc4e318045a85eb4aed775f9f5dc
parent d31a06e2b1aa11386bd0803129138fba986e4927

internal/backport/go/build: remove unnecessary copies of package variables

These variables never change, we don't need second copies of them.

Change-Id: I79fec284402dd709af1c2f9a7edf24f2c83d9d8b
Reviewed-on: https://go-review.googlesource.com/c/website/+/429576
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>

internal/backport/go/build/build.go

diff --git a/internal/backport/go/build/build.go b/internal/backport/go/build/build.go
index 12866e7..01aab3c 100644
--- a/internal/backport/go/build/build.go
+++ b/internal/backport/go/build/build.go
@@ -1438,10 +1438,7 @@
 }
 
 var (
-	bSlashSlash = []byte(slashSlash)
-	bStarSlash  = []byte(starSlash)
-	bSlashStar  = []byte(slashStar)
-	bPlusBuild  = []byte("+build")
+	bPlusBuild = []byte("+build")
 
 	goBuildComment = []byte("//go:build")
 
@@ -1510,7 +1507,7 @@
 				p = p[len(p):]
 			}
 			line = bytes.TrimSpace(line)
-			if !bytes.HasPrefix(line, bSlashSlash) || !bytes.Contains(line, bPlusBuild) {
+			if !bytes.HasPrefix(line, slashSlash) || !bytes.Contains(line, bPlusBuild) {
 				continue
 			}
 			text := string(line)
@@ -1579,12 +1576,12 @@
 				}
 				continue Lines
 			}
-			if bytes.HasPrefix(line, bSlashSlash) {
+			if bytes.HasPrefix(line, slashSlash) {
 				continue Lines
 			}
-			if bytes.HasPrefix(line, bSlashStar) {
+			if bytes.HasPrefix(line, slashStar) {
 				inSlashStar = true
-				line = bytes.TrimSpace(line[len(bSlashStar):])
+				line = bytes.TrimSpace(line[len(slashStar):])
 				continue Comments
 			}
 			// Found non-comment text.