internal/screentest: test output improvements
Updated test output to improve discoverability
of failed tests.
Change-Id: I4d70873d47f8cd91f613f6a7b529047e4b4fc053
Reviewed-on: https://go-review.googlesource.com/c/website/+/384841
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Jamal Carvalho <jamalcarvalho@google.com>
diff --git a/internal/screentest/screentest.go b/internal/screentest/screentest.go
index e7f4aa7..d7c2d68 100644
--- a/internal/screentest/screentest.go
+++ b/internal/screentest/screentest.go
@@ -645,7 +645,7 @@
// screenshots do not match.
func (tc *testcase) run(ctx context.Context, update bool) (err error) {
now := time.Now()
- fmt.Fprintf(&tc.output, "test %s\n", tc.name)
+ fmt.Fprintf(&tc.output, "test %s ", tc.name)
var screenA, screenB *image.Image
g, ctx := errgroup.WithContext(ctx)
g.Go(func() error {
@@ -663,7 +663,7 @@
return nil
})
if err := g.Wait(); err != nil {
- fmt.Fprint(&tc.output, err)
+ fmt.Fprint(&tc.output, "\n", err)
return err
}
result := imgdiff.Diff(*screenA, *screenB, &imgdiff.Options{
@@ -672,10 +672,10 @@
})
since := time.Since(now).Truncate(time.Millisecond)
if result.Equal {
- fmt.Fprintf(&tc.output, "%s == %s (%s)\n", tc.urlA, tc.urlB, since)
+ fmt.Fprintf(&tc.output, "(%s)\n", since)
return nil
}
- fmt.Fprintf(&tc.output, "%s != %s (%s)\n", tc.urlA, tc.urlB, since)
+ fmt.Fprintf(&tc.output, "(%s)\nFAIL %s != %s\n", since, tc.urlA, tc.urlB)
g = &errgroup.Group{}
g.Go(func() error {
return writePNG(&result.Image, tc.outDiff)
