vulncheck: improves handling of binary extensions in unit testing
Change-Id: I05ba16e632d9e5fde6514d7f07199f041be18eca
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/397454
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Zvonimir Pavlinovic <zpavlinovic@google.com>
diff --git a/vulncheck/binary_test.go b/vulncheck/binary_test.go
index 7041a2c..1d5210c 100644
--- a/vulncheck/binary_test.go
+++ b/vulncheck/binary_test.go
@@ -89,7 +89,7 @@
})
defer e.Cleanup()
- cmd := exec.Command("go", "build")
+ cmd := exec.Command("go", "build", "-o", "entry")
cmd.Dir = e.Config.Dir
cmd.Env = e.Config.Env
out, err := cmd.CombinedOutput()
@@ -97,13 +97,7 @@
t.Fatalf("failed to build the binary %v %v", err, string(out))
}
- binExt := ""
- // TODO: is there a better way to do this?
- if runtime.GOOS == "windows" {
- binExt = ".exe"
- }
-
- bin, err := os.Open(filepath.Join(e.Config.Dir, "entry"+binExt))
+ bin, err := os.Open(filepath.Join(e.Config.Dir, "entry"))
if err != nil {
t.Fatalf("failed to access the binary %v", err)
}
