.github/workflows: install stable delve version for testing
The extension maintains two dlv binaries for debugging, a stable
version of dlv for the legacy adapater and dlv built from master
to be used with dlv dap, which is under active development. For
testing we should use the stable version of delve for the legacy,
and only use master for dlv-dap.
Updates golang/vscode-go#1456
Change-Id: Ie4482aebb4fee1579896702faca207182b4746c3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/314389
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
diff --git a/.github/workflows/release-nightly.yml b/.github/workflows/release-nightly.yml
index cc9d8f6..8a2681b 100644
--- a/.github/workflows/release-nightly.yml
+++ b/.github/workflows/release-nightly.yml
@@ -65,7 +65,7 @@
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv@master
cp "${HOME}/go/bin/dlv${{env.EXT}}" "${HOME}/go/bin/dlv-dap${{env.EXT}}"
-
+ go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-long-all.yml b/.github/workflows/test-long-all.yml
index 20ea53c..92355de 100644
--- a/.github/workflows/test-long-all.yml
+++ b/.github/workflows/test-long-all.yml
@@ -61,7 +61,7 @@
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv@master
cp "${HOME}/go/bin/dlv${{env.EXT}}" "${HOME}/go/bin/dlv-dap${{env.EXT}}"
-
+ go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-long.yml b/.github/workflows/test-long.yml
index fa77e01..f09442a 100644
--- a/.github/workflows/test-long.yml
+++ b/.github/workflows/test-long.yml
@@ -60,6 +60,7 @@
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv@master
cp "${HOME}/go/bin/dlv${{env.EXT}}" "${HOME}/go/bin/dlv-dap${{env.EXT}}"
+ go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/.github/workflows/test-smoke.yml b/.github/workflows/test-smoke.yml
index 523d40a..2d64133 100644
--- a/.github/workflows/test-smoke.yml
+++ b/.github/workflows/test-smoke.yml
@@ -58,6 +58,7 @@
go get github.com/ramya-rao-a/go-outline
go get github.com/go-delve/delve/cmd/dlv@master
cp "${HOME}/go/bin/dlv${{env.EXT}}" "${HOME}/go/bin/dlv-dap${{env.EXT}}"
+ go get github.com/go-delve/delve/cmd/dlv
env:
GO111MODULE: on
EXT: "${{ matrix.os == 'windows-latest' && '.exe' || ''}}"
diff --git a/test/integration/goDebug.test.ts b/test/integration/goDebug.test.ts
index 130819a..73b9b5f 100644
--- a/test/integration/goDebug.test.ts
+++ b/test/integration/goDebug.test.ts
@@ -877,8 +877,7 @@
});
});
- // Temporarily disabled to unblock nightly release. (https://github.com/golang/vscode-go/issues/1456)
- suite.skip('remote attach', () => {
+ suite('remote attach', () => {
let childProcess: cp.ChildProcess;
let server: number;
let debugConfig: DebugConfiguration;
@@ -976,7 +975,7 @@
await dc.hitBreakpoint(debugConfig, getBreakpointLocation(FILE, BREAKPOINT_LINE));
});
- test.skip('stopped for a breakpoint set during initialization (remote attach)', async function () {
+ test('stopped for a breakpoint set during initialization (remote attach)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
this.skip(); // not working in dlv-dap.
}
@@ -1001,7 +1000,7 @@
await new Promise((resolve) => setTimeout(resolve, 2_000));
});
- test.skip('stopped for a breakpoint set after initialization (remote attach)', async function () {
+ test('stopped for a breakpoint set after initialization (remote attach)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
this.skip(); // not working in dlv-dap.
}
