commit da7328b341565ca8efb1df66ec681a5174a03c57
author Hana (Hyang-Ah) Kim <hyangah@gmail.com> Thu Aug 27 22:29:15 2020 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Fri Aug 28 14:38:32 2020 +0000
tree 58da9c4e5a45b86b16605f7f8f6d4bdb63905ab3
parent 4b52e4302cff28d3785f163994c0876a7264254b

package.json: disable debug config's showGlobalVariables by default

The feature of showing global variables when debugging
requires calling ListPackageVars and that is expensive in many cases.
Disable by default.

Fixes golang/vscode-go#138.

Change-Id: I24eb89fcb03f4bf6973186b55a8e5881271c0849
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/251264
Reviewed-by: Polina Sokolova <polina@google.com>

docs/debugging.md

diff --git a/docs/debugging.md b/docs/debugging.md
index 0a0af89..51e754e 100644
--- a/docs/debugging.md
+++ b/docs/debugging.md
@@ -66,7 +66,7 @@
     * `maxStructFields`: Maximum number of fields read from a struct. A setting of `-1` indicates that all fields should be read (default: `-1`).
     * `maxVariableRecurse`: How far to recurse when evaluating nested types (default: `1`).
     * `followPointers`: Automatically dereference pointers (default: `true`).
-  * `showGlobalVariables`: Show global variables in the Debug view (default: `true`).
+  * `showGlobalVariables`: Show global variables in the Debug view (default: `false`).
 
 There are some common cases when you might want to tweak the Delve configurations.
 

docs/settings.md

diff --git a/docs/settings.md b/docs/settings.md
index d702c68..754eff9 100644
--- a/docs/settings.md
+++ b/docs/settings.md
@@ -129,7 +129,7 @@
 Default:{<br/>
 &nbsp;&nbsp;`"apiVersion": 2`,<br/>
 &nbsp;&nbsp;`"dlvLoadConfig": map[followPointers:true maxArrayValues:64 maxStringLen:64 maxStructFields:-1 maxVariableRecurse:1]`,<br/>
-&nbsp;&nbsp;`"showGlobalVariables": true`,<br/>
+&nbsp;&nbsp;`"showGlobalVariables": false`,<br/>
     }
 
 

package.json

diff --git a/package.json b/package.json
index efbc3bf..16d43be 100644
--- a/package.json
+++ b/package.json
@@ -620,7 +620,7 @@
               },
               "showGlobalVariables": {
                 "type": "boolean",
-                "default": true,
+                "default": false,
                 "description": "Boolean value to indicate whether global package variables should be shown in the variables pane or not."
               }
             }
@@ -750,7 +750,7 @@
               },
               "showGlobalVariables": {
                 "type": "boolean",
-                "default": true,
+                "default": false,
                 "description": "Boolean value to indicate whether global package variables should be shown in the variables pane or not."
               }
             }
@@ -1003,7 +1003,7 @@
               },
               "showGlobalVariables": {
                 "type": "boolean",
-                "default": true,
+                "default": false,
                 "description": "Boolean value to indicate whether global package variables should be shown in the variables pane or not."
               }
             }
@@ -1125,7 +1125,7 @@
               },
               "showGlobalVariables": {
                 "type": "boolean",
-                "default": true,
+                "default": false,
                 "description": "Boolean value to indicate whether global package variables should be shown in the variables pane or not."
               }
             }
@@ -1894,7 +1894,7 @@
             "showGlobalVariables": {
               "type": "boolean",
               "description": "Boolean value to indicate whether global package variables should be shown in the variables pane or not.",
-              "default": true
+              "default": false
             }
           },
           "default": {
@@ -1906,7 +1906,7 @@
               "maxStructFields": -1
             },
             "apiVersion": 2,
-            "showGlobalVariables": true
+            "showGlobalVariables": false
           },
           "description": "Delve settings that applies to all debugging sessions. Debug configuration in the launch.json file will override these values.",
           "scope": "resource"