commit d533d37003f2cf2c46c5a69c97b054bf887121e3
author Hana <hyangah@gmail.com> Sat Oct 24 10:43:59 2020 -0400
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Mon Oct 26 18:17:23 2020 +0000
tree 24b0d3bd68ad55c031756d11bfa2e1993af1a6f6
parent 46f249de0ee502a66c259f99e29cc1338bdebf13

build/all.bash: adjust home directory used in gerrit CI

Recent changes in kokoro seem to restrict access to the root directories
other than /workspace. Place all directories we need write permission fo
under /workspace directory. That includes the home directory (where npm
and the vscode test framework store downloaded data and configuration by
default) and the default GOPATH directory ($HOME/go) under which tests
copy test fixtures.

Fixes golang/vscode-go#833

Change-Id: I85ad64d253df31f782d29ae0fe994945210567cc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/264877
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>

build/Dockerfile

diff --git a/build/Dockerfile b/build/Dockerfile
index 026e667..62a5b98 100644
--- a/build/Dockerfile
+++ b/build/Dockerfile
@@ -12,13 +12,18 @@
 
 FROM node:latest
 
+# Prepare a home directory under workspace.
+RUN mkdir -p /workspace/vscodego
+ENV HOME=/workspace/vscodego
+
 # GO111MODULE=auto
 RUN mkdir /go
 COPY --from=gobuilder /gobin /go/bin
 COPY --from=gobuilder /usr/local/go /usr/local/go
 
-ENV GOPATH /go
-ENV PATH ${GOPATH}/bin:/usr/local/go/bin:${PATH}
+# Add the default GOPATH/bin to the PATH.
+# Add the directories of the go tool chains to PATH.
+ENV PATH /workspace/vscodego/go/bin:/go/bin:/usr/local/go/bin:${PATH}
 ENV DEBIAN_FRONTEND noninteractive
 
 RUN apt-get update && apt-get install -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0

build/all.bash

diff --git a/build/all.bash b/build/all.bash
index c622653..f91df52 100755
--- a/build/all.bash
+++ b/build/all.bash
@@ -89,20 +89,20 @@
 
 # setup dependencies required for tests.
 install_dependencies() {
-	GO111MODULE=on go get -x golang.org/x/tools/gopls
-	GO111MODULE=on go get -x github.com/acroca/go-symbols
-	GO111MODULE=on go get -x github.com/cweill/gotests/...
-	GO111MODULE=on go get -x github.com/davidrjenni/reftools/cmd/fillstruct
-	GO111MODULE=on go get -x github.com/haya14busa/goplay/cmd/goplay
-	GO111MODULE=on go get -x github.com/mdempsky/gocode
-	GO111MODULE=on go get -x github.com/ramya-rao-a/go-outline
-	GO111MODULE=on go get -x github.com/rogpeppe/godef
-	GO111MODULE=on go get -x github.com/sqs/goreturns
-	GO111MODULE=on go get -x github.com/uudashr/gopkgs/v2/cmd/gopkgs
-	GO111MODULE=on go get -x github.com/zmb3/gogetdoc
-	GO111MODULE=on go get -x golang.org/x/lint/golint
-	GO111MODULE=on go get -x golang.org/x/tools/cmd/gorename
-	GO111MODULE=on go get -x github.com/go-delve/delve/cmd/dlv
+	GO111MODULE=on go get golang.org/x/tools/gopls
+	GO111MODULE=on go get github.com/acroca/go-symbols
+	GO111MODULE=on go get github.com/cweill/gotests/...
+	GO111MODULE=on go get github.com/davidrjenni/reftools/cmd/fillstruct
+	GO111MODULE=on go get github.com/haya14busa/goplay/cmd/goplay
+	GO111MODULE=on go get github.com/mdempsky/gocode
+	GO111MODULE=on go get github.com/ramya-rao-a/go-outline
+	GO111MODULE=on go get github.com/rogpeppe/godef
+	GO111MODULE=on go get github.com/sqs/goreturns
+	GO111MODULE=on go get github.com/uudashr/gopkgs/v2/cmd/gopkgs
+	GO111MODULE=on go get github.com/zmb3/gogetdoc
+	GO111MODULE=on go get golang.org/x/lint/golint
+	GO111MODULE=on go get golang.org/x/tools/cmd/gorename
+	GO111MODULE=on go get github.com/go-delve/delve/cmd/dlv
 }
 
 main() {