commit cbb14795b88ad4e38011bee6e458120b89b8eb07
author Hana <hyangah@gmail.com> Fri Feb 26 20:09:29 2021 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Mon Mar 01 03:52:49 2021 +0000
tree 53767327dededb6c379f6ba6d4097a4b8ed4d055
parent 6c0bda2fda191c408607b9ff73f4df661edceb8e

src/goModules: check goVersion isn't null before using it

Added similar check in goVet - but in such case, the vet
will fail later in runTools.

Fixes golang/vscode-go#1251

Change-Id: I226a107606e5633584ff1e337efa5762d245099a
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/297132
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>

src/goModules.ts

diff --git a/src/goModules.ts b/src/goModules.ts
index 6366741..eb8cae1 100644
--- a/src/goModules.ts
+++ b/src/goModules.ts
@@ -58,7 +58,7 @@
 		return moduleCache;
 	}
 	const goVersion = await getGoVersion();
-	if (goVersion.lt('1.11')) {
+	if (!goVersion || goVersion.lt('1.11')) {
 		return;
 	}
 

src/goVet.ts

diff --git a/src/goVet.ts b/src/goVet.ts
index dbfb3ea..09ec8b7 100644
--- a/src/goVet.ts
+++ b/src/goVet.ts
@@ -105,7 +105,7 @@
 	}
 
 	let vetArgs = ['vet', ...args, ...tagsArg, vetWorkspace ? './...' : '.'];
-	if (goVersion.lt('1.10') && args.length) {
+	if (goVersion && goVersion.lt('1.10') && args.length) {
 		vetArgs = ['tool', 'vet', ...args, ...tagsArg, '.'];
 	}