src/goDebugFactory: add --check-go-version=false
If https://github.com/go-delve/delve/pull/2684 is in,
users who use go versions outside delve's officially
supported version range, will have visible warnings.
Otherwise, we will need to have our own custom version
check and make the warning visible.
Fixes golang/vscode-go#1716
Change-Id: Ide76978b038f4efecdf3485abdcae37323855af5
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/347562
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
index b2c3fe3..c1ecc45 100644
--- a/src/goDebugFactory.ts
+++ b/src/goDebugFactory.ts
@@ -367,8 +367,11 @@
const dlvArgs = new Array<string>();
dlvArgs.push('dap');
- // add user-specified dlv flags first. When duplicate flags are specified,
+ // When duplicate flags are specified,
// dlv doesn't mind but accepts the last flag value.
+ // Add user-specified dlv flags first except
+ // --check-go-version that we want to disable by default but allow users to override.
+ dlvArgs.push('--check-go-version=false');
if (launchAttachArgs.dlvFlags && launchAttachArgs.dlvFlags.length > 0) {
dlvArgs.push(...launchAttachArgs.dlvFlags);
}
