test: remove symlink tests for substitutePath
Although these tests do work right now, they depend on the implementation
of the go command in a way I do not fully understand. The rest of the tests
are sufficient to test the substitutePath implementation as opposed to
how symlinks are interpreted by go or dlv. substitutePath may not be necessary
for all symlinked projects.
For example, when running on darwin:
$ ls ~/go/src/github.com/user/package
main.go
$ ln -s ~/go/src/github.com/user ~/githubuser/
$ cd ~/githubuser/package; dlv debug
(dlv) sources
~/go/src/github.com/user/package/main.go
If a go.mod file is added into the package in the GOPATH:
$ ls ~/go/src/github.com/user/package
main.go
go.mod
$ ln -s ~/go/src/github.com/user ~/githubuser/
$ cd ~/githubuser/package; dlv debug
(dlv) sources
~/githubuser/package/main.go
Updates golang/vscode-go#622
Change-Id: Ie9893ac3cdcac3a8efcda95056dca6df271a85bd
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/277961
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
diff --git a/test/integration/goDebug.test.ts b/test/integration/goDebug.test.ts
index 92a8fb8..272e4d8 100644
--- a/test/integration/goDebug.test.ts
+++ b/test/integration/goDebug.test.ts
@@ -1297,68 +1297,6 @@
rmdirRecursive(tmpDir);
});
- suite('substitutePath with symlinks', () => {
- let linkedDir: string;
- setup(() => {
- linkedDir = path.join(tmpDir, 'src');
- fs.symlinkSync(DATA_ROOT, linkedDir);
- });
-
- teardown(() => {
- fs.unlinkSync(linkedDir);
- });
-
- test('should stop on a breakpoint set in file with substituted path', () => {
- const PROGRAM_TEMP = path.join(linkedDir, 'baseTest');
- const PROGRAM = path.join(DATA_ROOT, 'baseTest');
-
- const FILE = path.join(PROGRAM_TEMP, 'test.go');
- const BREAKPOINT_LINE = 11;
-
- const config = {
- name: 'Launch',
- type: 'go',
- request: 'launch',
- mode: 'auto',
- program: PROGRAM_TEMP,
- substitutePath: [
- {
- from: PROGRAM_TEMP,
- to: PROGRAM
- }
- ]
- };
- const debugConfig = debugConfigProvider.resolveDebugConfiguration(undefined, config);
-
- return dc.hitBreakpoint(debugConfig, getBreakpointLocation(FILE, BREAKPOINT_LINE));
- });
-
- test('should stop on a breakpoint in test file with substituted path', () => {
- const PROGRAM_TEMP = path.join(linkedDir, 'baseTest');
- const PROGRAM = path.join(DATA_ROOT, 'baseTest');
-
- const FILE = path.join(PROGRAM_TEMP, 'sample_test.go');
- const BREAKPOINT_LINE = 15;
-
- const config = {
- name: 'Launch file',
- type: 'go',
- request: 'launch',
- mode: 'test',
- program: PROGRAM_TEMP,
- substitutePath: [
- {
- from: PROGRAM_TEMP,
- to: PROGRAM
- }
- ]
- };
- const debugConfig = debugConfigProvider.resolveDebugConfiguration(undefined, config);
-
- return dc.hitBreakpoint(debugConfig, getBreakpointLocation(FILE, BREAKPOINT_LINE));
- });
- });
-
function copyDirectory(name: string) {
const from = path.join(DATA_ROOT, name);
const to = path.join(tmpDir, name);
