commit 7c79ef41d32cdcd45c7d0737e17083cd598dbfe5
author Jamal Carvalho <jamal@golang.org> Tue May 17 15:54:18 2022 +0000
committer Jamal Carvalho <jamal@golang.org> Wed May 18 15:02:42 2022 +0000
tree 9ea0f41f05bf3181a73b189c275b29ce89d30695
parent 3b44015988d373f20783c32c440d30dd75eb60d0

vscode-go: unify tsconfig for build and test

Now that all strict type errors are fixed, we can unify
the tsconfig.

Fixes golang/vscode-go#57.

Change-Id: If60e91c29826be6dafe9d614f0f0186cc8349b3f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/406304
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>

build/all.bash

diff --git a/build/all.bash b/build/all.bash
index 6fd0c3c..4a1a7ed 100755
--- a/build/all.bash
+++ b/build/all.bash
@@ -45,7 +45,6 @@
   echo "**** Run test ****"
   df -h | grep shm
   npm ci
-  npm run typecheck
   npm run compile
   npm run unit-test
   npm test --silent

package.json

diff --git a/package.json b/package.json
index a74f079..94e40f7 100644
--- a/package.json
+++ b/package.json
@@ -38,10 +38,9 @@
     "bundle": "esbuild src/goMain.ts debugAdapter=src/debugAdapter/goDebug.ts --bundle --outdir=dist --external:vscode --format=cjs --platform=node",
     "bundle-dev": "npm run bundle -- --sourcemap",
     "bundle-watch": "npm run bundle -- --sourcemap --watch",
-    "test-compile": "tsc -p ./tsconfig.build.json",
-    "typecheck": "tsc -p ./tsconfig.strict.json --noEmit",
+    "test-compile": "tsc -p ./",
     "compile": "npm run bundle",
-    "watch": "tsc -watch -p ./tsconfig.build.json",
+    "watch": "tsc -watch -p ./",
     "test": "npm run test-compile && node ./out/test/runTest.js",
     "lint": "gts lint src test",
     "fix-lint": "gts fix src test",

tsconfig.build.json

diff --git a/tsconfig.build.json b/tsconfig.build.json
deleted file mode 100644
index c578434..0000000
--- a/tsconfig.build.json
+++ /dev/null
@@ -1,11 +0,0 @@
-{
-	"extends": "./tsconfig.json",
-	"compilerOptions": {
-		"strict": false,
-		"noImplicitAny": true,
-		"noImplicitThis": true,
-		"alwaysStrict": true,
-		"strictBindCallApply": true,
-		"strictFunctionTypes": true,
-	}
-}
\ No newline at end of file

tsconfig.strict.json

diff --git a/tsconfig.strict.json b/tsconfig.strict.json
deleted file mode 100644
index e25c93e..0000000
--- a/tsconfig.strict.json
+++ /dev/null
@@ -1,9 +0,0 @@
-{
-	"extends": "./tsconfig.json",
-	"exclude": [
-		"node_modules",
-		"third_party",
-		"test/integration",
-		"test/mocks"
-	]
-}
\ No newline at end of file