| commit | 6fad3bcf18dc7ce895df6d3afc21eb0e00ea5834 | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Wed Jul 15 12:13:07 2020 -0400 |
| committer | Hyang-Ah Hana Kim <hyangah@gmail.com> | Tue Jul 21 20:15:17 2020 +0000 |
| tree | fdaee0163f265b47f285ad6d94ec15e1300393d6 | |
| parent | a6c4f179bb674e1893587ed01821b650418bd9ca [diff] |
[release] goTools: don't fail gocode installation if gocode is not already running Fixes golang/vscode-go#355 Fixes golang/vscode-go#362 Change-Id: Ifdf229ce52a6a4b1a2e4f0a28ac5596405ff4c56 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/242780 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> (cherry picked from commit db1d1b3da6173d033c158b5586efe30374ff4d0a) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/243898 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/src/goTools.ts b/src/goTools.ts index eaa2b87..91d72dc 100644 --- a/src/goTools.ts +++ b/src/goTools.ts
@@ -194,7 +194,7 @@ return `Installing gocode aborted as existing process cannot be closed. Please kill the running process for gocode and try again.`; } } catch (err) { - return `Failed to close gocode process: ${err}.`; + // This may fail if gocode isn't already running. } return ''; },