[tslint] apply member-access rule
diff --git a/src/debugAdapter/goDebug.ts b/src/debugAdapter/goDebug.ts
index 7805230..caccacf 100644
--- a/src/debugAdapter/goDebug.ts
+++ b/src/debugAdapter/goDebug.ts
@@ -292,21 +292,21 @@
}
class Delve {
- program: string;
- remotePath: string;
- localDebugeePath: string | undefined;
- debugProcess: ChildProcess;
- loadConfig: LoadConfig;
- connection: Promise<RPCConnection>;
- onstdout: (str: string) => void;
- onstderr: (str: string) => void;
- onclose: (code: number) => void;
- noDebug: boolean;
- isApiV1: boolean;
- dlvEnv: any;
- stackTraceDepth: number;
- isRemoteDebugging: boolean;
- request: 'attach' | 'launch';
+ public program: string;
+ public remotePath: string;
+ private localDebugeePath: string | undefined;
+ private debugProcess: ChildProcess;
+ public loadConfig: LoadConfig;
+ public connection: Promise<RPCConnection>;
+ public onstdout: (str: string) => void;
+ public onstderr: (str: string) => void;
+ public onclose: (code: number) => void;
+ public noDebug: boolean;
+ public isApiV1: boolean;
+ public dlvEnv: any;
+ public stackTraceDepth: number;
+ public isRemoteDebugging: boolean;
+ private request: 'attach' | 'launch';
constructor(launchArgs: LaunchRequestArguments | AttachRequestArguments, program: string) {
this.request = launchArgs.request;
diff --git a/src/diffUtils.ts b/src/diffUtils.ts
index 3462813..1542132 100644
--- a/src/diffUtils.ts
+++ b/src/diffUtils.ts
@@ -20,10 +20,10 @@
export enum EditTypes { EDIT_DELETE, EDIT_INSERT, EDIT_REPLACE }
export class Edit {
- action: number;
- start: Position;
- end: Position;
- text: string;
+ private action: number;
+ public start: Position;
+ public end: Position;
+ public text: string;
constructor(action: number, start: Position) {
this.action = action;
@@ -32,7 +32,7 @@
}
// Creates TextEdit for current Edit
- apply(): TextEdit {
+ public apply(): TextEdit {
switch (this.action) {
case EditTypes.EDIT_INSERT:
return TextEdit.insert(this.start, this.text);
@@ -46,7 +46,7 @@
}
// Applies Edit using given TextEditorEdit
- applyUsingTextEditorEdit(editBuilder: TextEditorEdit): void {
+ public applyUsingTextEditorEdit(editBuilder: TextEditorEdit): void {
switch (this.action) {
case EditTypes.EDIT_INSERT:
editBuilder.insert(this.start, this.text);
@@ -63,7 +63,7 @@
}
// Applies Edits to given WorkspaceEdit
- applyUsingWorkspaceEdit(workspaceEdit: WorkspaceEdit, fileUri: Uri): void {
+ public applyUsingWorkspaceEdit(workspaceEdit: WorkspaceEdit, fileUri: Uri): void {
switch (this.action) {
case EditTypes.EDIT_INSERT:
workspaceEdit.insert(fileUri, this.start, this.text);
diff --git a/src/goBaseCodelens.ts b/src/goBaseCodelens.ts
index 59cf69c..8536072 100644
--- a/src/goBaseCodelens.ts
+++ b/src/goBaseCodelens.ts
@@ -20,7 +20,7 @@
}
}
- provideCodeLenses(document: vscode.TextDocument, token: vscode.CancellationToken): vscode.ProviderResult<vscode.CodeLens[]> {
+ public provideCodeLenses(document: vscode.TextDocument, token: vscode.CancellationToken): vscode.ProviderResult<vscode.CodeLens[]> {
return [];
}
diff --git a/src/goSuggest.ts b/src/goSuggest.ts
index ecd3a78..87d46e5 100644
--- a/src/goSuggest.ts
+++ b/src/goSuggest.ts
@@ -48,9 +48,9 @@
}
class ExtendedCompletionItem extends vscode.CompletionItem {
- package?: string;
- receiver?: string;
- fileName: string;
+ public package?: string;
+ public receiver?: string;
+ public fileName: string;
}
const lineCommentFirstWordRegex = /^\s*\/\/\s+[\S]*$/;
diff --git a/src/goTypeDefinition.ts b/src/goTypeDefinition.ts
index a762261..d19d134 100644
--- a/src/goTypeDefinition.ts
+++ b/src/goTypeDefinition.ts
@@ -32,7 +32,7 @@
}
export class GoTypeDefinitionProvider implements vscode.TypeDefinitionProvider {
- provideTypeDefinition(document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken): vscode.ProviderResult<vscode.Definition> {
+ public provideTypeDefinition(document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken): vscode.ProviderResult<vscode.Definition> {
const adjustedPos = adjustWordPosition(document, position);
if (!adjustedPos[0]) {
return Promise.resolve(null);
diff --git a/src/util.ts b/src/util.ts
index 178ca9d..c3a65d8 100644
--- a/src/util.ts
+++ b/src/util.ts
@@ -70,9 +70,9 @@
]);
export class GoVersion {
- sv: semver.SemVer;
- commit: string;
- isDevel: boolean;
+ public sv: semver.SemVer;
+ private commit: string;
+ public isDevel: boolean;
constructor(version: string) {
const matchesRelease = /go version go(\d.\d+).*/.exec(version);
@@ -86,14 +86,14 @@
sendTelemetryEventForGoVersion(this.format());
}
- format(): string {
+ public format(): string {
if (this.sv) {
return this.sv.format();
}
return `devel +${this.commit}`;
}
- lt(version: string): boolean {
+ public lt(version: string): boolean {
// Assume a developer version is always above any released version.
// This is not necessarily true.
if (this.isDevel || !this.sv) {
@@ -102,7 +102,7 @@
return semver.lt(this.sv, semver.coerce(version));
}
- gt(version: string): boolean {
+ public gt(version: string): boolean {
// Assume a developer version is always above any released version.
// This is not necessarily true.
if (this.isDevel || !this.sv) {
@@ -472,7 +472,7 @@
private lineListeners: { (line: string): void; }[] = [];
private lastListeners: { (last: string): void; }[] = [];
- append(chunk: string) {
+ public append(chunk: string) {
this.buf += chunk;
do {
const idx = this.buf.indexOf('\n');
@@ -485,7 +485,7 @@
} while (true);
}
- done() {
+ public done() {
this.fireDone(this.buf !== '' ? this.buf : null);
}
@@ -497,11 +497,11 @@
this.lastListeners.forEach((listener) => listener(last));
}
- onLine(listener: (line: string) => void) {
+ public onLine(listener: (line: string) => void) {
this.lineListeners.push(listener);
}
- onDone(listener: (last: string) => void) {
+ public onDone(listener: (last: string) => void) {
this.lastListeners.push(listener);
}
}
diff --git a/tslint.json b/tslint.json
index c758164..5d22efc 100644
--- a/tslint.json
+++ b/tslint.json
@@ -61,7 +61,7 @@
"options": 2
},
// "max-line-length": { "options": 120 },
- // "member-access": true,
+ "member-access": true,
// "member-ordering": {
// "options": {
// "order": "statics-first"
