test/integration/goDebug.test.ts: include reasons for cwd test fail
The cwd tests were failing using dlv-dap. I investigated these
failures and discovered they were failing for two reasons.
1. The user specified cwd was not being applied during launch
2. There were no Output events being sent for noDebug
I updated the comments with a link to a PR to fix (1) and included
the issue that makes (2) fail. Although fixing (2) would cause these
tests to pass, there will probably be other work necessary to
implement noDebug.
Change-Id: Iefd3c02d26a99961513a5e386f7e784e88a869d4
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/295895
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Polina Sokolova <polina@google.com>
diff --git a/test/integration/goDebug.test.ts b/test/integration/goDebug.test.ts
index b7591b0..c1a3695 100644
--- a/test/integration/goDebug.test.ts
+++ b/test/integration/goDebug.test.ts
@@ -681,7 +681,7 @@
suite('set current working directory', () => {
test('should debug program with cwd set', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // Fixed in https://github.com/go-delve/delve/pull/2360
}
const WD = path.join(DATA_ROOT, 'cwdTest');
@@ -703,11 +703,7 @@
await assertLocalVariableValue('strdat', '"Hello, World!"');
});
- test('should debug program without cwd set', async function () {
- if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
- }
-
+ test('should debug program without cwd set', async () => {
const WD = path.join(DATA_ROOT, 'cwdTest');
const PROGRAM = path.join(WD, 'cwdTest');
const FILE = path.join(PROGRAM, 'main.go');
@@ -728,7 +724,7 @@
test('should debug file program with cwd set', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // Fixed in https://github.com/go-delve/delve/pull/2360
}
const WD = path.join(DATA_ROOT, 'cwdTest');
@@ -750,11 +746,7 @@
await assertLocalVariableValue('strdat', '"Hello, World!"');
});
- test('should debug file program without cwd set', async function () {
- if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
- }
-
+ test('should debug file program without cwd set', async () => {
const WD = path.join(DATA_ROOT, 'cwdTest');
const PROGRAM = path.join(WD, 'cwdTest', 'main.go');
const FILE = PROGRAM;
@@ -776,7 +768,7 @@
test('should run program with cwd set (noDebug)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // OutputEvents not implemented
}
const WD = path.join(DATA_ROOT, 'cwdTest');
@@ -802,7 +794,7 @@
test('should run program without cwd set (noDebug)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // OutputEvents not implemented
}
const WD = path.join(DATA_ROOT, 'cwdTest');
@@ -827,7 +819,7 @@
test('should run file program with cwd set (noDebug)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // OutputEvents not implemented
}
const WD = path.join(DATA_ROOT, 'cwdTest');
@@ -853,7 +845,7 @@
test('should run file program without cwd set (noDebug)', async function () {
if (isDlvDap && dlvDapSkipsEnabled) {
- this.skip(); // not working in dlv-dap.
+ this.skip(); // OutputEvents not implemented
}
const WD = path.join(DATA_ROOT, 'cwdTest');
