stop registerLanguageFeatures cleanly when the binary is not installed (#3015)
The caller and getLanguageServerToolPath already detected the missing
binary and offered to install the missing tool. So, simply returning
immediately is ok, and prevents the warning messages such as not
handling promise on time, or accessing non-existing property of
tool.name in shouldUpdateLanguageServer.
diff --git a/src/goLanguageServer.ts b/src/goLanguageServer.ts
index e7e7b45..5763326 100644
--- a/src/goLanguageServer.ts
+++ b/src/goLanguageServer.ts
@@ -78,9 +78,17 @@
// The user has opted into the language server.
const languageServerToolPath = getLanguageServerToolPath();
const toolName = getToolFromToolPath(languageServerToolPath);
+ if (!toolName) {
+ // language server binary is not installed yet.
+ // Return immediately. The information messages such as
+ // offering to install missing tools, and suggesting to
+ // reload the window after installing the language server
+ // should be presented by now.
+ return;
+ }
const env = getToolsEnvVars();
- // The user may not have the most up-to-date version of the language server.
+ // If installed, check. The user may not have the most up-to-date version of the language server.
const tool = getTool(toolName);
const update = await shouldUpdateLanguageServer(tool, languageServerToolPath, config.checkForUpdates);
if (update) {
