src/goDebugFactory: re-enable version check
Passing --check-go-version=false without informing the user leads to
suppressing important warnings and confusion.
Fixes go-delve/delve#3058
Change-Id: Ib5aea336f3ea8a0c6d859e5d82562da12dc54a9c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/455175
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
diff --git a/src/goDebugFactory.ts b/src/goDebugFactory.ts
index 4972ab0..ae82e2e 100644
--- a/src/goDebugFactory.ts
+++ b/src/goDebugFactory.ts
@@ -643,13 +643,8 @@
const dlvArgs = new Array<string>();
dlvArgs.push('dap');
- // TODO(hyangah): if Go version is higher than what the delve can support, we need to warn users.
-
// When duplicate flags are specified,
// dlv doesn't mind but accepts the last flag value.
- // Add user-specified dlv flags first except
- // --check-go-version that we want to disable by default but allow users to override.
- dlvArgs.push('--check-go-version=false');
if (launchAttachArgs.dlvFlags && launchAttachArgs.dlvFlags.length > 0) {
dlvArgs.push(...launchAttachArgs.dlvFlags);
}
