commit 0f196ff781efc684da21d7b18504f5b0b8ea5173
author Rebecca Stambler <rstambler@golang.org> Fri Sep 17 14:34:53 2021 -0400
committer Rebecca Stambler <rstambler@golang.org> Mon Sep 20 16:14:36 2021 +0000
tree 85fa3efda3936201935d3a88f40ac695eadbe166
parent 171cc61baa9b58bf370d20d6ef29926f14580bd8

package.json: support testAtCursor (and co.) despite codelenses

We've decided to disable these by default, but support them even if you
have the `run test` codelenses.

Fixes golang/vscode-go#1768

Change-Id: Ia873f63fa89a90f73d90124ef58b2aad517410e7
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/350769
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>

docs/settings.md

diff --git a/docs/settings.md b/docs/settings.md
index 5f34fdc..2d5922c 100644
--- a/docs/settings.md
+++ b/docs/settings.md
@@ -182,15 +182,15 @@
 | --- | --- |
 | `addImport` | If true, adds command to import a package to the editor context menu <br/> Default: `true` |
 | `addTags` | If true, adds command to add configured tags from struct fields to the editor context menu <br/> Default: `true` |
-| `benchmarkAtCursor` | If true, adds command to benchmark the test under the cursor to the editor context menu <br/> Default: `true` |
-| `debugTestAtCursor` | If true, adds command to debug the test under the cursor to the editor context menu <br/> Default: `true` |
+| `benchmarkAtCursor` | If true, adds command to benchmark the test under the cursor to the editor context menu <br/> Default: `false` |
+| `debugTestAtCursor` | If true, adds command to debug the test under the cursor to the editor context menu <br/> Default: `false` |
 | `fillStruct` | If true, adds command to fill struct literal with default values to the editor context menu <br/> Default: `true` |
 | `generateTestForFile` | If true, adds command to generate unit tests for current file to the editor context menu <br/> Default: `true` |
 | `generateTestForFunction` | If true, adds command to generate unit tests for function under the cursor to the editor context menu <br/> Default: `true` |
 | `generateTestForPackage` | If true, adds command to generate unit tests for currnt package to the editor context menu <br/> Default: `true` |
 | `playground` | If true, adds command to upload the current file or selection to the Go Playground <br/> Default: `true` |
 | `removeTags` | If true, adds command to remove configured tags from struct fields to the editor context menu <br/> Default: `true` |
-| `testAtCursor` | If true, adds command to run the test under the cursor to the editor context menu <br/> Default: `true` |
+| `testAtCursor` | If true, adds command to run the test under the cursor to the editor context menu <br/> Default: `false` |
 | `testCoverage` | If true, adds command to run test coverage to the editor context menu <br/> Default: `true` |
 | `testFile` | If true, adds command to run all tests in the current file to the editor context menu <br/> Default: `true` |
 | `testPackage` | If true, adds command to run all tests in the current package to the editor context menu <br/> Default: `true` |

package.json

diff --git a/package.json b/package.json
index 7503d30..80b7b83 100644
--- a/package.json
+++ b/package.json
@@ -1662,7 +1662,7 @@
             },
             "testAtCursor": {
               "type": "boolean",
-              "default": true,
+              "default": false,
               "description": "If true, adds command to run the test under the cursor to the editor context menu"
             },
             "testFile": {
@@ -1707,12 +1707,12 @@
             },
             "debugTestAtCursor": {
               "type": "boolean",
-              "default": true,
+              "default": false,
               "description": "If true, adds command to debug the test under the cursor to the editor context menu"
             },
             "benchmarkAtCursor": {
               "type": "boolean",
-              "default": true,
+              "default": false,
               "description": "If true, adds command to benchmark the test under the cursor to the editor context menu"
             }
           },
@@ -2443,17 +2443,17 @@
           "group": "Go group 1"
         },
         {
-          "when": "editorTextFocus && config.go.editorContextMenuCommands.testAtCursor && resourceLangId == go && !config.editor.codeLens",
+          "when": "editorTextFocus && config.go.editorContextMenuCommands.testAtCursor && resourceLangId == go",
           "command": "go.test.cursor",
           "group": "Go group 1"
         },
         {
-          "when": "editorTextFocus && config.go.editorContextMenuCommands.benchmarkAtCursor && resourceLangId == go && !config.editor.codeLens",
+          "when": "editorTextFocus && config.go.editorContextMenuCommands.benchmarkAtCursor && resourceLangId == go",
           "command": "go.benchmark.cursor",
           "group": "Go group 1"
         },
         {
-          "when": "editorTextFocus && config.go.editorContextMenuCommands.debugTestAtCursor && resourceLangId == go && !config.editor.codeLens",
+          "when": "editorTextFocus && config.go.editorContextMenuCommands.debugTestAtCursor && resourceLangId == go",
           "command": "go.debug.cursor",
           "group": "Go group 1"
         },