commit 0dee1a800d02c69551fef9d72a547077a08b828d
author Hana <hyangah@gmail.com> Fri Dec 11 22:28:23 2020 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Sat Dec 12 13:34:31 2020 +0000
tree f72d658d3d19e6291698cc4c9259d6dd38027804
parent 1812139bafa15cc3ca407816be330c2435b80e23

src/goInstallTools: fix broken gocode-gomod install

?? is misused. It should be || because at some point
the extension sets GOBIN to ''.

Change-Id: I206e290da9a21abbfb1cc0a90a3fda6dec6a65d6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/277293
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>

src/goInstallTools.ts

diff --git a/src/goInstallTools.ts b/src/goInstallTools.ts
index d34b4ff..d4fddd8 100644
--- a/src/goInstallTools.ts
+++ b/src/goInstallTools.ts
@@ -245,7 +245,7 @@
 		logVerbose(`install: %s %s\n%s%s`, goBinary, args.join(' '), stdout, stderr);
 
 		if (hasModSuffix(tool)) {  // Actual installation of the -gomod tool is done by running go build.
-			const gopath = env['GOBIN'] ?? env['GOPATH'];
+			const gopath = env['GOBIN'] || env['GOPATH'];
 			if (!gopath) {
 				return `GOBIN/GOPATH not configured in environment`;
 			}