commit | 7c0cf33f39ccf5d8e4c59d34a150425ddac7df6a | [log] [tgz] |
---|---|---|
author | Dennis Kuhnert <mail.kuhnert@gmail.com> | Mon May 21 23:57:40 2018 +0200 |
committer | Russ Cox <rsc@golang.org> | Fri May 25 16:57:20 2018 +0000 |
tree | 7dad03fd3f87793860a18ffabf1fd3683ff498cb | |
parent | c4312af18b72fd65dc7928a5fd719b5868c133f3 [diff] |
cmd/go/internal/modfetch: fix bug in parsing non-quoted module paths CL 105215 introduced "allow, prefer unquoted strings in mod files", so autogenerated go.mod files do not contain quotes in the module path. Before, `modPath` could only handle quoted module paths. This lead to bugs like `vgo install github.com/Kyroy/vgoversion2/v2` installing v1.0.0 instead of v2.1.0 because `isMajor` returned false instead of true due to the wrong return of modPath. Hence, `findDir` returned "missing go.mod" error. Now, `modPath` is able to parse quoted and non-quoted module paths. Change-Id: I24b0a4cd60ce928b123fb1b347edf84f018f01a6 Reviewed-on: https://go-review.googlesource.com/114058 Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Russ Cox <rsc@golang.org> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This repository holds a prototype of what the go command might look like with integrated support for package versioning.
See research.swtch.com/vgo for documents about the design.
Use go get -u golang.org/x/vgo
.
You can also manually git clone the repository to $GOPATH/src/golang.org/x/vgo
.
See CONTRIBUTING.md.
This is still a very early prototype. You are likely to run into bugs. Please file bugs in the main Go issue tracker, golang.org/issue, and put the prefix x/vgo:
in the issue title.
Thank you.