commit aef6c802ede697bfc71a740ccd720cc12c6de29b
author Andrew Austin <andrewaclt@gmail.com> Fri Sep 25 00:33:19 2015 -0400
committer Andrew Gerrand <adg@golang.org> Fri Sep 25 04:56:06 2015 +0000
tree 7fce8c200ac1527bb3abe63c6e2d7c94a5893e80
parent 8d9b4afbe662bf86a6747fef6d7f3f7112307c34

tour: fix pageup/pagedown navigation on non-chrome browsers

FF and IE fail to populate event.keyCode, but instead populate
event.which with the key code. event.key is a DOMString of "PageUp"
or "PageDown" in this case, so remove the invalid comparision to a
numeric key code and instead compare the keycode to event.which.

Fixes golang/go#8829

Change-Id: I7192d2e561e2be5472018d8a3b06a91ab9dab49b
Reviewed-on: https://go-review.googlesource.com/15001
Reviewed-by: Andrew Gerrand <adg@golang.org>

static/js/directives.js

diff --git a/static/js/directives.js b/static/js/directives.js
index c4f287c..de2e12e 100755
--- a/static/js/directives.js
+++ b/static/js/directives.js
@@ -13,7 +13,7 @@
     return function(scope, elm, attrs) {
         elm.attr('tabindex', 0);
         elm.keyup(function(evt) {
-            var key = evt.key || evt.keyCode;
+            var key = evt.which || evt.keyCode;
             if (key == 33 && !evt.ctrlKey) {
                 scope.$apply(attrs.onpageup);
                 evt.preventDefault();
@@ -27,7 +27,7 @@
     return function(scope, elm, attrs) {
         elm.attr('tabindex', 0);
         elm.keyup(function(evt) {
-            var key = evt.key || evt.keyCode;
+            var key = evt.which || evt.keyCode;
             if (key == 34 && !evt.ctrlKey) {
                 scope.$apply(attrs.onpagedown);
                 evt.preventDefault();