Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 1 | // Copyright 2019 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
| 5 | package memoize_test |
| 6 | |
| 7 | import ( |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 8 | "context" |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 9 | "sync" |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 10 | "testing" |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 11 | "time" |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 12 | |
| 13 | "golang.org/x/tools/internal/memoize" |
| 14 | ) |
| 15 | |
Heschi Kreinick | c1903db | 2020-07-24 17:17:13 -0400 | [diff] [blame] | 16 | func TestGet(t *testing.T) { |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 17 | var store memoize.Store |
Rebecca Stambler | ecc01b7 | 2019-06-11 21:16:35 -0400 | [diff] [blame] | 18 | |
Heschi Kreinick | c1903db | 2020-07-24 17:17:13 -0400 | [diff] [blame] | 19 | evaled := 0 |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 20 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 21 | h, release := store.Promise("key", func(context.Context, interface{}) interface{} { |
Heschi Kreinick | c1903db | 2020-07-24 17:17:13 -0400 | [diff] [blame] | 22 | evaled++ |
| 23 | return "res" |
Alan Donovan | f042799 | 2022-07-01 10:35:27 -0400 | [diff] [blame] | 24 | }) |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 25 | defer release() |
| 26 | expectGet(t, h, "res") |
| 27 | expectGet(t, h, "res") |
Heschi Kreinick | c1903db | 2020-07-24 17:17:13 -0400 | [diff] [blame] | 28 | if evaled != 1 { |
| 29 | t.Errorf("got %v calls to function, wanted 1", evaled) |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 30 | } |
| 31 | } |
| 32 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 33 | func expectGet(t *testing.T, h *memoize.Promise, wantV interface{}) { |
Rob Findley | d36b6f6 | 2020-10-20 11:10:46 -0400 | [diff] [blame] | 34 | t.Helper() |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 35 | gotV, gotErr := h.Get(context.Background(), nil) |
Heschi Kreinick | c1903db | 2020-07-24 17:17:13 -0400 | [diff] [blame] | 36 | if gotV != wantV || gotErr != nil { |
| 37 | t.Fatalf("Get() = %v, %v, wanted %v, nil", gotV, gotErr, wantV) |
Ian Cottrell | f8d1dee | 2019-05-10 16:36:20 -0400 | [diff] [blame] | 38 | } |
| 39 | } |
| 40 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 41 | func TestNewPromise(t *testing.T) { |
| 42 | calls := 0 |
| 43 | f := func(context.Context, interface{}) interface{} { |
| 44 | calls++ |
| 45 | return calls |
| 46 | } |
| 47 | |
| 48 | // All calls to Get on the same promise return the same result. |
| 49 | p1 := memoize.NewPromise("debug", f) |
| 50 | expectGet(t, p1, 1) |
| 51 | expectGet(t, p1, 1) |
| 52 | |
| 53 | // A new promise calls the function again. |
| 54 | p2 := memoize.NewPromise("debug", f) |
| 55 | expectGet(t, p2, 2) |
| 56 | expectGet(t, p2, 2) |
| 57 | |
| 58 | // The original promise is unchanged. |
| 59 | expectGet(t, p1, 1) |
| 60 | } |
| 61 | |
| 62 | func TestStoredPromiseRefCounting(t *testing.T) { |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 63 | var store memoize.Store |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 64 | v1 := false |
| 65 | v2 := false |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 66 | p1, release1 := store.Promise("key1", func(context.Context, interface{}) interface{} { |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 67 | return &v1 |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 68 | }) |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 69 | p2, release2 := store.Promise("key2", func(context.Context, interface{}) interface{} { |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 70 | return &v2 |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 71 | }) |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 72 | expectGet(t, p1, &v1) |
| 73 | expectGet(t, p2, &v2) |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 74 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 75 | expectGet(t, p1, &v1) |
| 76 | expectGet(t, p2, &v2) |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 77 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 78 | p2Copy, release2Copy := store.Promise("key2", func(context.Context, interface{}) interface{} { |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 79 | return &v1 |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 80 | }) |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 81 | if p2 != p2Copy { |
| 82 | t.Error("Promise returned a new value while old is not destroyed yet") |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 83 | } |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 84 | expectGet(t, p2Copy, &v2) |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 85 | |
| 86 | release2() |
| 87 | if got, want := v2, false; got != want { |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 88 | t.Errorf("after destroying first v2 ref, got %v, want %v", got, want) |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 89 | } |
| 90 | release2Copy() |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 91 | if got, want := v1, false; got != want { |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 92 | t.Errorf("after destroying v2, got %v, want %v", got, want) |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 93 | } |
| 94 | release1() |
| 95 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 96 | p2Copy, release2Copy = store.Promise("key2", func(context.Context, interface{}) interface{} { |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 97 | return &v2 |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 98 | }) |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 99 | if p2 == p2Copy { |
| 100 | t.Error("Promise returned previously destroyed value") |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 101 | } |
| 102 | release2Copy() |
Ruslan Nigmatullin | f60e9bc | 2022-06-22 00:22:43 +0000 | [diff] [blame] | 103 | } |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 104 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 105 | func TestPromiseDestroyedWhileRunning(t *testing.T) { |
| 106 | // Test that calls to Promise.Get return even if the promise is destroyed while running. |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 107 | |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 108 | var store memoize.Store |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 109 | c := make(chan int) |
| 110 | |
| 111 | var v int |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 112 | h, release := store.Promise("key", func(ctx context.Context, _ interface{}) interface{} { |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 113 | <-c |
| 114 | <-c |
| 115 | if err := ctx.Err(); err != nil { |
| 116 | t.Errorf("ctx.Err() = %v, want nil", err) |
| 117 | } |
| 118 | return &v |
| 119 | }) |
| 120 | |
| 121 | ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) // arbitrary timeout; may be removed if it causes flakes |
| 122 | defer cancel() |
| 123 | |
| 124 | var wg sync.WaitGroup |
| 125 | wg.Add(1) |
| 126 | var got interface{} |
| 127 | var err error |
| 128 | go func() { |
Alan Donovan | 53ead67 | 2022-07-05 10:30:58 -0400 | [diff] [blame] | 129 | got, err = h.Get(ctx, nil) |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 130 | wg.Done() |
| 131 | }() |
| 132 | |
Alan Donovan | db8f89b | 2022-07-13 16:34:32 -0400 | [diff] [blame] | 133 | c <- 0 // send once to enter the promise function |
| 134 | release() // release before the promise function returns |
| 135 | c <- 0 // let the promise function proceed |
Robert Findley | 56116ec | 2022-06-26 15:17:46 -0400 | [diff] [blame] | 136 | |
| 137 | wg.Wait() |
| 138 | |
| 139 | if err != nil { |
| 140 | t.Errorf("Get() failed: %v", err) |
| 141 | } |
| 142 | if got != &v { |
| 143 | t.Errorf("Get() = %v, want %v", got, v) |
| 144 | } |
| 145 | } |
Robert Findley | 98bfcd1 | 2022-07-27 15:59:52 -0400 | [diff] [blame] | 146 | |
| 147 | func TestDoubleReleasePanics(t *testing.T) { |
| 148 | var store memoize.Store |
| 149 | _, release := store.Promise("key", func(ctx context.Context, _ interface{}) interface{} { return 0 }) |
| 150 | |
| 151 | panicked := false |
| 152 | |
| 153 | func() { |
| 154 | defer func() { |
| 155 | if recover() != nil { |
| 156 | panicked = true |
| 157 | } |
| 158 | }() |
| 159 | release() |
| 160 | release() |
| 161 | }() |
| 162 | |
| 163 | if !panicked { |
| 164 | t.Errorf("calling release() twice did not panic") |
| 165 | } |
| 166 | } |