| commit | 294080fd2f5aedacec87d7670af9d16000dd2d2f | [log] [tgz] |
|---|---|---|
| author | Robert Findley <rfindley@google.com> | Wed Mar 16 13:18:41 2022 -0400 |
| committer | Dmitri Shuralyov <dmitshur@golang.org> | Tue Mar 29 15:07:52 2022 +0000 |
| tree | 11943a79d99628536ffbdf2d57cfa66cd59326a7 | |
| parent | 97de9ec466464c82f5b546f2826a6a11b183cf7d [diff] |
go/types/objectpath: break cycles through type parameters in find When searching for objects, we naively traversed through type parameter constraints. This leads to infinite recursion when there are cycles through type parameter constraints. Break these cycles by tracking type parameter names that have previously been encountered. This ensures we walk type parameter constraints at most once. Note that if the desired object was not found on the first search of the constraint, there is no need to search again. Note: this cherry-pick also adjusts a test error message to match go1.18. Updates golang/go#51727 Change-Id: Ifcdf4b138a0e95441e485bbb9ee21c01b04eaed4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/393376 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org> (cherry picked from commit d67eab4bcee20484daf13001afb781a117bc49ec) Reviewed-on: https://go-review.googlesource.com/c/tools/+/393635 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.