tree 11943a79d99628536ffbdf2d57cfa66cd59326a7
parent 97de9ec466464c82f5b546f2826a6a11b183cf7d
author Robert Findley <rfindley@google.com> 1647451121 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> 1648566472 +0000

go/types/objectpath: break cycles through type parameters in find

When searching for objects, we naively traversed through type parameter
constraints. This leads to infinite recursion when there are cycles
through type parameter constraints.

Break these cycles by tracking type parameter names that have previously
been encountered. This ensures we walk type parameter constraints at
most once. Note that if the desired object was not found on the first
search of the constraint, there is no need to search again.

Note: this cherry-pick also adjusts a test error message to match
go1.18.

Updates golang/go#51727

Change-Id: Ifcdf4b138a0e95441e485bbb9ee21c01b04eaed4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/393376
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
(cherry picked from commit d67eab4bcee20484daf13001afb781a117bc49ec)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/393635
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>