| commit | fe56e63357632a74e1c5d77333b471aa69997fd6 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Fri Jan 17 16:20:39 2020 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Fri Jan 17 21:50:04 2020 +0000 |
| tree | 0f02e8e883acecf848a2e922466d10afb6befa7e | |
| parent | 1486df0b25589885baa57479b10c95a201027acf [diff] |
internal/lsp/source: fix ranking of untyped completions Claiming that untyped candidates matched the type of whatever we were looking for messed up rankings in found(). The only other places that use it will all work better with false. Return false. Updates golang/go#36591. Change-Id: I5e1e8af7cc5c27422740cbb77f9a4a20edb1e447 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215322 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/internal/lsp/source/completion.go b/internal/lsp/source/completion.go index 7039ab5..6eb56c9 100644 --- a/internal/lsp/source/completion.go +++ b/internal/lsp/source/completion.go
@@ -1695,7 +1695,7 @@ candType := cand.obj.Type() if candType == nil { - return true + return false } // Default to invoking *types.Func candidates. This is so function