internal/lsp/cache: only refresh imports cache every 30 seconds
Loading completion suggestions can be slow, especially in GOPATH mode
where basically anything can change at any time. As a compromise, cache
everything for 30 seconds. Specifically, after a completion operation
finishes, if the cache is more than 30 seconds old, refresh it
asynchronously. That keeps user-facing latency consistent, without
chewing up CPU when the editor isn't in use. It does mean that if you
walk away for an hour and come back, the first completion may be stale.
In module mode this is relatively benign. The only things the
longer caching affects are the main module and replace targets, and
relevant packages in those will generally be loaded by gopls, so they'll
have full, up-to-date type information regardless.
In GOPATH mode this may be more troublesome, since it affects
everything. In particular, go get -u of a package that isn't imported
yet won't be reflected until the cache period expires. I think that's a
rare enough case not to worry about.
Change-Id: Iaadfd0ff647cda2b1dcdead9254b5492b397e86e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/205163
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/internal/imports/fix.go b/internal/imports/fix.go
index 7fd5130..916ddf3 100644
--- a/internal/imports/fix.go
+++ b/internal/imports/fix.go
@@ -846,6 +846,8 @@
// loadExports returns the set of exported symbols in the package at dir.
// loadExports may be called concurrently.
loadExports(ctx context.Context, pkg *pkg) (string, []string, error)
+
+ ClearForNewScan()
}
// gopackagesResolver implements resolver for GOPATH and module workspaces using go/packages.
@@ -853,6 +855,8 @@
env *ProcessEnv
}
+func (r *goPackagesResolver) ClearForNewScan() {}
+
func (r *goPackagesResolver) loadPackageNames(importPaths []string, srcDir string) (map[string]string, error) {
if len(importPaths) == 0 {
return nil, nil
@@ -1032,6 +1036,10 @@
}
}
+func (r *gopathResolver) ClearForNewScan() {
+ r.cache = nil
+}
+
func (r *gopathResolver) loadPackageNames(importPaths []string, srcDir string) (map[string]string, error) {
r.init()
names := map[string]string{}
diff --git a/internal/lsp/cache/view.go b/internal/lsp/cache/view.go
index 2a5c45e..118a21d 100644
--- a/internal/lsp/cache/view.go
+++ b/internal/lsp/cache/view.go
@@ -14,6 +14,7 @@
"os/exec"
"strings"
"sync"
+ "time"
"golang.org/x/tools/go/packages"
"golang.org/x/tools/internal/imports"
@@ -22,6 +23,7 @@
"golang.org/x/tools/internal/lsp/source"
"golang.org/x/tools/internal/span"
"golang.org/x/tools/internal/telemetry/log"
+ "golang.org/x/tools/internal/telemetry/tag"
"golang.org/x/tools/internal/xcontext"
errors "golang.org/x/xerrors"
)
@@ -59,7 +61,8 @@
// TODO(suzmue): the state cached in the process env is specific to each view,
// however, there is state that can be shared between views that is not currently
// cached, like the module cache.
- processEnv *imports.ProcessEnv
+ processEnv *imports.ProcessEnv
+ cacheRefreshTime time.Time
// modFileVersions stores the last seen versions of the module files that are used
// by processEnvs resolver.
@@ -142,12 +145,8 @@
}
// Before running the user provided function, clear caches in the resolver.
- if r, ok := v.processEnv.GetResolver().(*imports.ModuleResolver); ok {
- if v.modFilesChanged() {
- r.ClearForNewMod()
- } else {
- r.ClearForNewScan()
- }
+ if v.modFilesChanged() {
+ v.processEnv.GetResolver().(*imports.ModuleResolver).ClearForNewMod()
}
// Run the user function.
@@ -155,11 +154,27 @@
if err := fn(opts); err != nil {
return err
}
+ if v.cacheRefreshTime.IsZero() {
+ v.cacheRefreshTime = time.Now()
+ }
// If applicable, store the file versions of the 'go.mod' files that are
// looked at by the resolver.
v.storeModFileVersions()
+ if time.Since(v.cacheRefreshTime) > 30*time.Second {
+ go func() {
+ v.mu.Lock()
+ defer v.mu.Unlock()
+
+ log.Print(context.Background(), "background imports cache refresh starting")
+ v.processEnv.GetResolver().ClearForNewScan()
+ _, err := imports.GetAllCandidates("", opts)
+ v.cacheRefreshTime = time.Now()
+ log.Print(context.Background(), "background refresh finished with err: ", tag.Of("err", err))
+ }()
+ }
+
return nil
}
