internal/lsp: remove gopls-<name> configuration
This was an undocumented and unused option to allow users some extra
per-workspace folder configuration. Editor clients need to offer that
support for it to be useful, and right now, none do. Remove the
configuration now so that we don't have to support it in the future.
For more context, see the discussion on golang/go#41966.
Fixes golang/go#41966.
Change-Id: I820b810d7a1ba02b0ec10cc47c79e670f7e67bb8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/269597
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
diff --git a/internal/lsp/general.go b/internal/lsp/general.go
index 3b940b8..2a42bdf 100644
--- a/internal/lsp/general.go
+++ b/internal/lsp/general.go
@@ -412,18 +412,14 @@
if !s.session.Options().ConfigurationSupported {
return nil
}
- v := protocol.ParamConfiguration{
+ configs, err := s.client.Configuration(ctx, &protocol.ParamConfiguration{
ConfigurationParams: protocol.ConfigurationParams{
Items: []protocol.ConfigurationItem{{
ScopeURI: string(folder),
Section: "gopls",
- }, {
- ScopeURI: string(folder),
- Section: fmt.Sprintf("gopls-%s", name),
}},
},
- }
- configs, err := s.client.Configuration(ctx, &v)
+ })
if err != nil {
return fmt.Errorf("failed to get workspace configuration from client (%s): %v", folder, err)
}
