commit | e854e0228e2ef1cc6e42bbfde1951925096a1272 | [log] [tgz] |
---|---|---|
author | Matthew Dempsky <mdempsky@google.com> | Thu Apr 14 11:55:07 2022 -0700 |
committer | Matthew Dempsky <mdempsky@google.com> | Tue Apr 19 22:48:11 2022 +0000 |
tree | a7298e16f37ab5c317188e8b9784e50bcddd42d7 | |
parent | c02adccb15cfeb6766a092581dbb193588b06387 [diff] |
go/ssa: fix miscompilation of <<= and >>= statements Unlike other binary operations, the RHS operand of a shift operation does not need to have the same type as the LHS operand. In particular, for "x <<= y" and "x >>= y" statements, coercing y to have the same type as x can lead to miscompilation. Fixes golang/go#52342. Change-Id: I3ff139afa18f5637d527bd4a0b10d6b40ce53ab4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/400394 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Tim King <taking@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go install
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.