tree a7298e16f37ab5c317188e8b9784e50bcddd42d7
parent c02adccb15cfeb6766a092581dbb193588b06387
author Matthew Dempsky <mdempsky@google.com> 1649962507 -0700
committer Matthew Dempsky <mdempsky@google.com> 1650408491 +0000

go/ssa: fix miscompilation of <<= and >>= statements

Unlike other binary operations, the RHS operand of a shift operation
does not need to have the same type as the LHS operand. In particular,
for "x <<= y" and "x >>= y" statements, coercing y to have the same
type as x can lead to miscompilation.

Fixes golang/go#52342.

Change-Id: I3ff139afa18f5637d527bd4a0b10d6b40ce53ab4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/400394
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tim King <taking@google.com>