| commit | e4b0a184d0f7248f56059b4b72f2c6aa26766d9e | [log] [tgz] |
|---|---|---|
| author | Zvonimir Pavlinovic <zpavlinovic@google.com> | Thu Jun 06 20:51:25 2024 +0000 |
| committer | Zvonimir Pavlinovic <zpavlinovic@google.com> | Wed Jun 12 09:20:43 2024 +0000 |
| tree | b933a628017988bde78ccc71aef6379a941b88da | |
| parent | f45db9b4bbd0d0c0eaad13a5be3ddd8da408f3da [diff] |
internal/checker: run despite all errors Previously, we would run an analysis when RunDespiteErrors=true only if all package errors were syntax or type errors. We should run the analysis on all errors. The previous design choice was motivated by a concern that list and unknown errors might indicate something unexpectedly wrong about the program. If RunDespiteErrors=true, then this would go under the users' radar. This design choice seems somewhat arbitrary and creates problems when a list error is a duplicate of a type error; the analysis is not executed despite a conceptually single type error. Further, package errors are always printed to stderr, so they are visible to users. Lastly, we return exit code 3 if there are any diagnostics. Otherwise, we return 1 exit code, if there are any packages errors. Fixes golang/go#67790 Change-Id: Ie3186a08ed3c8292033344aec35fc755a6d256f2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/591117 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.