)]}'
{
  "commit": "e4b0a184d0f7248f56059b4b72f2c6aa26766d9e",
  "tree": "b933a628017988bde78ccc71aef6379a941b88da",
  "parents": [
    "f45db9b4bbd0d0c0eaad13a5be3ddd8da408f3da"
  ],
  "author": {
    "name": "Zvonimir Pavlinovic",
    "email": "zpavlinovic@google.com",
    "time": "Thu Jun 06 20:51:25 2024 +0000"
  },
  "committer": {
    "name": "Zvonimir Pavlinovic",
    "email": "zpavlinovic@google.com",
    "time": "Wed Jun 12 09:20:43 2024 +0000"
  },
  "message": "internal/checker: run despite all errors\n\nPreviously, we would run an analysis when RunDespiteErrors\u003dtrue only\nif all package errors were syntax or type errors. We should run the\nanalysis on all errors.\n\nThe previous design choice was motivated by a concern that list and\nunknown errors might indicate something unexpectedly wrong about the\nprogram. If RunDespiteErrors\u003dtrue, then this would go under the users\u0027\nradar.\n\nThis design choice seems somewhat arbitrary and creates problems when a\nlist error is a duplicate of a type error; the analysis is not\nexecuted despite a conceptually single type error. Further, package\nerrors are always printed to stderr, so they are visible to users.\n\nLastly, we return exit code 3 if there are any diagnostics. Otherwise,\nwe return 1 exit code, if there are any packages errors.\n\nFixes golang/go#67790\n\nChange-Id: Ie3186a08ed3c8292033344aec35fc755a6d256f2\nReviewed-on: https://go-review.googlesource.com/c/tools/+/591117\nLUCI-TryBot-Result: Go LUCI \u003cgolang-scoped@luci-project-accounts.iam.gserviceaccount.com\u003e\nReviewed-by: Alan Donovan \u003cadonovan@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "52f0e55aaaee8ef20fb47619b068409a3cce7de3",
      "old_mode": 33188,
      "old_path": "go/analysis/internal/checker/checker.go",
      "new_id": "5a7146576a9c0792dc2ae4eb4f398ef911229137",
      "new_mode": 33188,
      "new_path": "go/analysis/internal/checker/checker.go"
    },
    {
      "type": "modify",
      "old_id": "69ea944d888bbb335f7e27f5f5ee2aa329bdf31b",
      "old_mode": 33188,
      "old_path": "go/analysis/internal/checker/checker_test.go",
      "new_id": "46c74d723282e7d6b7355c56d7fbae8f0ac085b0",
      "new_mode": 33188,
      "new_path": "go/analysis/internal/checker/checker_test.go"
    }
  ]
}