internal/lsp: remove staticcheck and gofumpt from all experiments
Change-Id: I7b60a06ca5442ce2736d3c1a2d55a0f91b4d44fc
Reviewed-on: https://go-review.googlesource.com/c/tools/+/263197
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
diff --git a/gopls/internal/regtest/diagnostics_test.go b/gopls/internal/regtest/diagnostics_test.go
index 394c5a75..8404ea1 100644
--- a/gopls/internal/regtest/diagnostics_test.go
+++ b/gopls/internal/regtest/diagnostics_test.go
@@ -1367,19 +1367,19 @@
-- main.go --
package main
-func main() {
- if true {}
-}`
+import "bytes"
+
+func b(c bytes.Buffer) {
+ _ = 1
+}
+`
withOptions(
EditorConfig{
AllExperiments: true,
},
).run(t, mod, func(t *testing.T, env *Env) {
- // Confirm that staticcheck is enabled.
- env.OpenFile("main.go")
- env.Await(
- env.DiagnosticAtRegexp("main.go", "if"),
- )
+ // Confirm that the setting doesn't cause any warnings.
+ env.Await(NoShowMessage())
})
}
diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go
index a80ab3b..bc60888 100644
--- a/internal/lsp/source/options.go
+++ b/internal/lsp/source/options.go
@@ -590,8 +590,6 @@
o.ExperimentalDiagnosticsDelay = 200 * time.Millisecond
o.ExperimentalWorkspaceModule = true
o.ExperimentalPackageCacheKey = true
- o.Staticcheck = true
- o.Gofumpt = true
o.SymbolStyle = DynamicSymbols
o.Codelens[CommandToggleDetails.Name] = true
o.Analyses[unusedparams.Analyzer.Name] = true
