commit d39bbca0a38c8407ab8046997c3cc0973f428995
author Johannes Altmanninger <aclopte@gmail.com> Tue Aug 24 23:49:47 2021 +0200
committer Rebecca Stambler <rstambler@golang.org> Fri Sep 03 18:04:29 2021 +0000
tree 6640dd53be2782805c2c0540723ce8c4996f19d5
parent 4e109c5706e4859e38d016dcb220036490f1418f

gopls: consistently capitalize enum variants for symbolStyle

We use a case-insensitive comparison so this doesn't really
matter but it's a bit confusing that gopls/doc/settings.md and
internal/lsp/source/api_json.go were inconsistent here.  I'm assuming
the latter also shows up as user-visible documentation somewhere,
probably in the VSCode plugin.

Change-Id: I14fa5b9d062266b6de0397aafb36e0ad84730752
Reviewed-on: https://go-review.googlesource.com/c/tools/+/344353
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Peter Weinberger <pjw@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>

gopls/doc/settings.md

diff --git a/gopls/doc/settings.md b/gopls/doc/settings.md
index 9af120d..ad7cf12 100644
--- a/gopls/doc/settings.md
+++ b/gopls/doc/settings.md
@@ -412,7 +412,7 @@
 ```json5
 "gopls": {
 ...
-  "symbolStyle": "dynamic",
+  "symbolStyle": "Dynamic",
 ...
 }
 ```

internal/lsp/source/api_json.go

diff --git a/internal/lsp/source/api_json.go b/internal/lsp/source/api_json.go
index f5e7e13..9b5734f 100755
--- a/internal/lsp/source/api_json.go
+++ b/internal/lsp/source/api_json.go
@@ -341,7 +341,7 @@
 			{
 				Name: "symbolStyle",
 				Type: "enum",
-				Doc:  "symbolStyle controls how symbols are qualified in symbol responses.\n\nExample Usage:\n\n```json5\n\"gopls\": {\n...\n  \"symbolStyle\": \"dynamic\",\n...\n}\n```\n",
+				Doc:  "symbolStyle controls how symbols are qualified in symbol responses.\n\nExample Usage:\n\n```json5\n\"gopls\": {\n...\n  \"symbolStyle\": \"Dynamic\",\n...\n}\n```\n",
 				EnumKeys: EnumKeys{
 					ValueType: "",
 					Keys:      nil,

internal/lsp/source/options.go

diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go
index bd94a3f..2594cb4 100644
--- a/internal/lsp/source/options.go
+++ b/internal/lsp/source/options.go
@@ -69,7 +69,7 @@
 
 // DefaultOptions is the options that are used for Gopls execution independent
 // of any externally provided configuration (LSP initialization, command
-// invokation, etc.).
+// invocation, etc.).
 func DefaultOptions() *Options {
 	optionsOnce.Do(func() {
 		var commands []string
@@ -411,7 +411,7 @@
 	// ```json5
 	// "gopls": {
 	// ...
-	//   "symbolStyle": "dynamic",
+	//   "symbolStyle": "Dynamic",
 	// ...
 	// }
 	// ```

internal/lsp/source/options_test.go

diff --git a/internal/lsp/source/options_test.go b/internal/lsp/source/options_test.go
index 83cb795..f8260c1 100644
--- a/internal/lsp/source/options_test.go
+++ b/internal/lsp/source/options_test.go
@@ -18,7 +18,7 @@
 	}{
 		{
 			name:  "symbolStyle",
-			value: "dynamic",
+			value: "Dynamic",
 			check: func(o Options) bool { return o.SymbolStyle == DynamicSymbols },
 		},
 		{