commit c86e6230b444560f2ae620b1cb7fbd578774964a
author Rebecca Stambler <rstambler@golang.org> Wed Oct 28 18:48:49 2020 -0400
committer Rebecca Stambler <rstambler@golang.org> Thu Oct 29 19:53:23 2020 +0000
tree 153aca71afb92cdab297918092612cd76acac0e5
parent e7a17c4c1366742d0088bef9c9c056bfdd1ce0dd

internal/lsp/source: add missing vet analyzers

Fixes golang/go#42263

Change-Id: I1493f39c3347d912d4d88a90cfe12bb30929360a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/266058
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>

internal/lsp/source/options.go

diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go
index e8ebe33..7126fb4 100644
--- a/internal/lsp/source/options.go
+++ b/internal/lsp/source/options.go
@@ -25,6 +25,7 @@
 	"golang.org/x/tools/go/analysis/passes/deepequalerrors"
 	"golang.org/x/tools/go/analysis/passes/errorsas"
 	"golang.org/x/tools/go/analysis/passes/httpresponse"
+	"golang.org/x/tools/go/analysis/passes/ifaceassert"
 	"golang.org/x/tools/go/analysis/passes/loopclosure"
 	"golang.org/x/tools/go/analysis/passes/lostcancel"
 	"golang.org/x/tools/go/analysis/passes/nilfunc"
@@ -32,6 +33,7 @@
 	"golang.org/x/tools/go/analysis/passes/shift"
 	"golang.org/x/tools/go/analysis/passes/sortslice"
 	"golang.org/x/tools/go/analysis/passes/stdmethods"
+	"golang.org/x/tools/go/analysis/passes/stringintconv"
 	"golang.org/x/tools/go/analysis/passes/structtag"
 	"golang.org/x/tools/go/analysis/passes/testinggoroutine"
 	"golang.org/x/tools/go/analysis/passes/tests"
@@ -959,31 +961,33 @@
 func defaultAnalyzers() map[string]Analyzer {
 	return map[string]Analyzer{
 		// The traditional vet suite:
-		asmdecl.Analyzer.Name:      {Analyzer: asmdecl.Analyzer, Enabled: true},
-		assign.Analyzer.Name:       {Analyzer: assign.Analyzer, Enabled: true},
-		atomic.Analyzer.Name:       {Analyzer: atomic.Analyzer, Enabled: true},
-		atomicalign.Analyzer.Name:  {Analyzer: atomicalign.Analyzer, Enabled: true},
-		bools.Analyzer.Name:        {Analyzer: bools.Analyzer, Enabled: true},
-		buildtag.Analyzer.Name:     {Analyzer: buildtag.Analyzer, Enabled: true},
-		cgocall.Analyzer.Name:      {Analyzer: cgocall.Analyzer, Enabled: true},
-		composite.Analyzer.Name:    {Analyzer: composite.Analyzer, Enabled: true},
-		copylock.Analyzer.Name:     {Analyzer: copylock.Analyzer, Enabled: true},
-		errorsas.Analyzer.Name:     {Analyzer: errorsas.Analyzer, Enabled: true},
-		httpresponse.Analyzer.Name: {Analyzer: httpresponse.Analyzer, Enabled: true},
-		loopclosure.Analyzer.Name:  {Analyzer: loopclosure.Analyzer, Enabled: true},
-		lostcancel.Analyzer.Name:   {Analyzer: lostcancel.Analyzer, Enabled: true},
-		nilfunc.Analyzer.Name:      {Analyzer: nilfunc.Analyzer, Enabled: true},
-		printf.Analyzer.Name:       {Analyzer: printf.Analyzer, Enabled: true},
-		shift.Analyzer.Name:        {Analyzer: shift.Analyzer, Enabled: true},
-		stdmethods.Analyzer.Name:   {Analyzer: stdmethods.Analyzer, Enabled: true},
-		structtag.Analyzer.Name:    {Analyzer: structtag.Analyzer, Enabled: true},
-		tests.Analyzer.Name:        {Analyzer: tests.Analyzer, Enabled: true},
-		unmarshal.Analyzer.Name:    {Analyzer: unmarshal.Analyzer, Enabled: true},
-		unreachable.Analyzer.Name:  {Analyzer: unreachable.Analyzer, Enabled: true},
-		unsafeptr.Analyzer.Name:    {Analyzer: unsafeptr.Analyzer, Enabled: true},
-		unusedresult.Analyzer.Name: {Analyzer: unusedresult.Analyzer, Enabled: true},
+		asmdecl.Analyzer.Name:       {Analyzer: asmdecl.Analyzer, Enabled: true},
+		assign.Analyzer.Name:        {Analyzer: assign.Analyzer, Enabled: true},
+		atomic.Analyzer.Name:        {Analyzer: atomic.Analyzer, Enabled: true},
+		bools.Analyzer.Name:         {Analyzer: bools.Analyzer, Enabled: true},
+		buildtag.Analyzer.Name:      {Analyzer: buildtag.Analyzer, Enabled: true},
+		cgocall.Analyzer.Name:       {Analyzer: cgocall.Analyzer, Enabled: true},
+		composite.Analyzer.Name:     {Analyzer: composite.Analyzer, Enabled: true},
+		copylock.Analyzer.Name:      {Analyzer: copylock.Analyzer, Enabled: true},
+		errorsas.Analyzer.Name:      {Analyzer: errorsas.Analyzer, Enabled: true},
+		httpresponse.Analyzer.Name:  {Analyzer: httpresponse.Analyzer, Enabled: true},
+		ifaceassert.Analyzer.Name:   {Analyzer: ifaceassert.Analyzer, Enabled: true},
+		loopclosure.Analyzer.Name:   {Analyzer: loopclosure.Analyzer, Enabled: true},
+		lostcancel.Analyzer.Name:    {Analyzer: lostcancel.Analyzer, Enabled: true},
+		nilfunc.Analyzer.Name:       {Analyzer: nilfunc.Analyzer, Enabled: true},
+		printf.Analyzer.Name:        {Analyzer: printf.Analyzer, Enabled: true},
+		shift.Analyzer.Name:         {Analyzer: shift.Analyzer, Enabled: true},
+		stdmethods.Analyzer.Name:    {Analyzer: stdmethods.Analyzer, Enabled: true},
+		stringintconv.Analyzer.Name: {Analyzer: stringintconv.Analyzer, Enabled: true},
+		structtag.Analyzer.Name:     {Analyzer: structtag.Analyzer, Enabled: true},
+		tests.Analyzer.Name:         {Analyzer: tests.Analyzer, Enabled: true},
+		unmarshal.Analyzer.Name:     {Analyzer: unmarshal.Analyzer, Enabled: true},
+		unreachable.Analyzer.Name:   {Analyzer: unreachable.Analyzer, Enabled: true},
+		unsafeptr.Analyzer.Name:     {Analyzer: unsafeptr.Analyzer, Enabled: true},
+		unusedresult.Analyzer.Name:  {Analyzer: unusedresult.Analyzer, Enabled: true},
 
 		// Non-vet analyzers:
+		atomicalign.Analyzer.Name:      {Analyzer: atomicalign.Analyzer, Enabled: true},
 		deepequalerrors.Analyzer.Name:  {Analyzer: deepequalerrors.Analyzer, Enabled: true},
 		sortslice.Analyzer.Name:        {Analyzer: sortslice.Analyzer, Enabled: true},
 		testinggoroutine.Analyzer.Name: {Analyzer: testinggoroutine.Analyzer, Enabled: true},