| commit | c024452afbcdebb4a0fbe1bb0eaea0d2dbff835b | [log] [tgz] |
|---|---|---|
| author | Pontus Leitzler <leitzler@gmail.com> | Sat Aug 22 19:35:59 2020 +0200 |
| committer | Robert Findley <rfindley@google.com> | Sun Aug 23 20:58:32 2020 +0000 |
| tree | 5aee7c9253818d4a30a60a60301c59b430f7fb0f | |
| parent | 307de81be3f473894f3f3052976fc9c2c0409b8e [diff] |
internal/lsp: don't panic if there are no suggested fixes If an analyzer doesn't return error, and doesn't have any suggested fixs either gopls panics. Return an empty set of edits instead. Change-Id: I1cd812fedcbd2ddc01229f48c0cc4467ee3f0105 Reviewed-on: https://go-review.googlesource.com/c/tools/+/249998 Reviewed-by: Robert Findley <rfindley@google.com>
diff --git a/internal/lsp/source/command.go b/internal/lsp/source/command.go index fb178c7..0de8cb5 100644 --- a/internal/lsp/source/command.go +++ b/internal/lsp/source/command.go
@@ -171,6 +171,10 @@ if err != nil { return nil, err } + if fix == nil { + return nil, nil + } + var edits []protocol.TextDocumentEdit for _, edit := range fix.TextEdits { rng := span.NewRange(fset, edit.Pos, edit.End)