commit | b30482dd32ce7e0e7445a4c97e488d84f7cbdb31 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Wed Feb 03 14:09:48 2021 -0800 |
committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 05 19:47:01 2021 +0000 |
tree | 95d35400cd6d19348f8409e1503c3c76e4e1c688 | |
parent | 513be0a9d2204093a2b84aed5a3dc3c18bb737b8 [diff] |
internal/lsp/cache: allow fixing multiple syntax errors Allow fixSrc to run multiple times on a file. For example: func main() { var s S if s.<> } type S struct { i int } To properly complete at <>, we need to perform two fixes. We must insert a phantom underscore after "s." to deal with the dangling selector, and then we must insert phantom "{}" for the "if" statement to deal with the incomplete "if" block. Previously we stopped at one fix, but now we allow for up to 10. I added a limit because I am afraid there are cases where we could get stuck trying to apply the same fix again and again. Also, drive-by set isIncomplete=true when we return early in lsp/completion.go. I have found my editor incorrectly caches this zero result in certain cases because it thinks results are "complete". Fixes golang/go#43471. Change-Id: Idd34cc164d579fa12a27920dc3afb372799abf26 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289271 Run-TryBot: Muir Manders <muir@mnd.rs> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.