| commit | 513be0a9d2204093a2b84aed5a3dc3c18bb737b8 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Jan 26 14:10:48 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Fri Feb 05 19:41:14 2021 +0000 |
| tree | 0d5c256f3bc3359675b92b5c1ef4f54623e49d13 | |
| parent | 8938cee73c2baa24cd58a044a94f5da9acfc43e1 [diff] |
internal/lsp/cache: disable network for mod tidy diagnostics The only thing that the mod tidy diagnostics use the network for is adding dependencies, and we already have quick fixes for those. The one exception is the case covered by TestBadlyVersionedModule, a dependency that fails to declare one of its own dependencies and therefore requires an indirect dependency in the workspace module. That only triggers an error on the dependency's import statement, which the user will never see. Fortunately, the go command does expose these problems in the DepsErrors field of the list response. Add an internal API to access that, and turn it into diagnostics on both the file and the controlling go.mod. Refactor the go get diagnostic generation so that it applies to both modules and packages. Fixes golang/go#38462. Change-Id: Ie2af940087654682a40de9ecfccd46f404a88b60 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289309 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.