| commit | ac2ed988c31e2293418dfa8c5cf591e0772881ea | [log] [tgz] |
|---|---|---|
| author | Damien Neil <dneil@google.com> | Wed Oct 13 14:22:43 2021 -0700 |
| committer | Damien Neil <dneil@google.com> | Wed Oct 13 22:21:08 2021 +0000 |
| tree | 888cbf6078530b3fd8c7b3cffd9de83b0dd4cc4e | |
| parent | 378b9e1d59e2352276eff57e8153a4ff4053d8a7 [diff] |
go/analysis/passes/printf: warn against using non-error interface values with %w CL 217180 permits passing interface values to any format verb, since we have no way of knowing if the underlying type implements fmt.Formatter. Restore the previous behavior of reporting an error for passing a non-error value to %w. The %w verb requires an error argument, and the risk of false positives is small. Fixes golang/go#48931 Change-Id: I83a6c9ed252976476f12372a490779336a1f536f Reviewed-on: https://go-review.googlesource.com/c/tools/+/355730 Trust: Damien Neil <dneil@google.com> Run-TryBot: Damien Neil <dneil@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.