tree 888cbf6078530b3fd8c7b3cffd9de83b0dd4cc4e
parent 378b9e1d59e2352276eff57e8153a4ff4053d8a7
author Damien Neil <dneil@google.com> 1634160163 -0700
committer Damien Neil <dneil@google.com> 1634163668 +0000

go/analysis/passes/printf: warn against using non-error interface values with %w

CL 217180 permits passing interface values to any format verb, since
we have no way of knowing if the underlying type implements
fmt.Formatter. Restore the previous behavior of reporting an error
for passing a non-error value to %w.  The %w verb requires an error
argument, and the risk of false positives is small.

Fixes golang/go#48931

Change-Id: I83a6c9ed252976476f12372a490779336a1f536f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/355730
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>