| commit | a8f40b3f4d73b4863d04b4ad6b0337d3a78f5eaa | [log] [tgz] |
|---|---|---|
| author | Ian Cottrell <iancottrell@google.com> | Thu Mar 28 21:06:01 2019 -0400 |
| committer | Ian Cottrell <iancottrell@google.com> | Fri Mar 29 19:31:51 2019 +0000 |
| tree | 577c06d0e98c2be4cdff3325115d08a58bad55d7 | |
| parent | 0926561711323f19c6649aaf9bf227d6addf1209 [diff] |
internal/jsonrpc2: split main loop from construction to fix race This changes the basic API of a jsonrpc2 connection to run the read loop as a method rather than in a go routine launched in the NewConn. This allows the handler to be created and bound between construction and the read loop starting, which fixes the race. Fixes golang/go#30091 Change-Id: I8201175affe431819cf473e5194d70c019f58425 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003 Run-TryBot: Ian Cottrell <iancottrell@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.