tree 577c06d0e98c2be4cdff3325115d08a58bad55d7
parent 0926561711323f19c6649aaf9bf227d6addf1209
author Ian Cottrell <iancottrell@google.com> 1553821561 -0400
committer Ian Cottrell <iancottrell@google.com> 1553887911 +0000

internal/jsonrpc2: split main loop from construction to fix race

This changes the basic API of a jsonrpc2 connection to run the
read loop as a method rather than in a go routine launched in
the NewConn. This allows the handler to be created and bound
between construction and the read loop starting, which fixes
the race.

Fixes golang/go#30091

Change-Id: I8201175affe431819cf473e5194d70c019f58425
Reviewed-on: https://go-review.googlesource.com/c/tools/+/170003
Run-TryBot: Ian Cottrell <iancottrell@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>